Updated tests

Author: nmayorsplit

dtos/impression.go

@@ -11,6 +11,7 @@ type Impression struct {
 	Time         int64  `json:"m"`
 	Pt           int64  `json:"pt,omitempty"`
 	Disabled     bool   `json:"-"`
+	Properties   string `json:"properties"`
 }
 
 // ImpressionQueueObject struct mapping impressions

service/api/http_recorders_test.go

@@ -15,7 +15,7 @@ import (
 )
 
 func TestImpressionRecord(t *testing.T) {
-	impressionTXT := `{"k":"some_key","t":"off","m":1234567890,"c":55555555,"r":"some label","b":"some_bucket_key"}`
+	impressionTXT := `{"k":"some_key","t":"off","m":1234567890,"c":55555555,"r":"some label","b":"some_bucket_key","properties":""}`
 	impressionRecord := &dtos.ImpressionDTO{
 		KeyName:      "some_key",
 		Treatment:    "off",
@@ -34,8 +34,29 @@ func TestImpressionRecord(t *testing.T) {
 	}
 }
 
+func TestImpressionRecordWithProperties(t *testing.T) {
+	impressionTXT := `{"k":"some_key","t":"off","m":1234567890,"c":55555555,"r":"some label","b":"some_bucket_key","properties":"value"}`
+	impressionRecord := &dtos.ImpressionDTO{
+		KeyName:      "some_key",
+		Treatment:    "off",
+		Time:         1234567890,
+		ChangeNumber: 55555555,
+		Label:        "some label",
+		BucketingKey: "some_bucket_key",
+		Properties:   "value"}
+
+	marshalImpression, err := json.Marshal(impressionRecord)
+	if err != nil {
+		t.Error(err)
+	}
+
+	if string(marshalImpression) != impressionTXT {
+		t.Error("Error marshaling impression")
+	}
+}
+
 func TestImpressionRecordBulk(t *testing.T) {
-	impressionTXT := `{"f":"some_feature","i":[{"k":"some_key","t":"off","m":1234567890,"c":55555555,"r":"some label","b":"some_bucket_key"}]}`
+	impressionTXT := `{"f":"some_feature","i":[{"k":"some_key","t":"off","m":1234567890,"c":55555555,"r":"some label","b":"some_bucket_key","properties":""}]}`
 	impressionRecords := &dtos.ImpressionsDTO{
 		TestName: "some_feature",
 		KeyImpressions: []dtos.ImpressionDTO{{
@@ -58,7 +79,7 @@ func TestImpressionRecordBulk(t *testing.T) {
 }
 
 func TestPostImpressions(t *testing.T) {
-	impressionsTXT := `[{"f":"some_test_2","i":[{"k":"some_key_1","t":"on","m":1234567890,"c":9876543210,"r":"some_label_1","b":"some_bucket_key_1"}]},{"f":"some_test","i":[{"k":"some_key_2","t":"off","m":1234567890,"c":9876543210,"r":"some_label_2","b":"some_bucket_key_2"}]}]`
+	impressionsTXT := `[{"f":"some_test_2","i":[{"k":"some_key_1","t":"on","m":1234567890,"c":9876543210,"r":"some_label_1","b":"some_bucket_key_1","properties":""}]},{"f":"some_test","i":[{"k":"some_key_2","t":"off","m":1234567890,"c":9876543210,"r":"some_label_2","b":"some_bucket_key_2","properties":""}]}]`
 	logger := logging.NewLogger(&logging.LoggerOptions{})
 
 	var expectedPT int64