polishing

Author: sanzmauro

service/api/specs/specversion.go

@@ -17,7 +17,6 @@ var FLAG_V1_1 = flagSpecs[1]
 var FLAG_V1_2 = flagSpecs[2]
 
 var Latest = string(flagSpecs[len(flagSpecs)-1])
-var Default = string(flagSpecs[0])
 
 // Match returns the spec version if it is valid, otherwise it returns nil
 func Match(version string) *string {
@@ -32,7 +31,7 @@ func Match(version string) *string {
 func ParseAndValidate(spec string) (string, error) {
 	if len(spec) == 0 {
 		// return default flag spec
-		return Default, nil
+		return FLAG_V1_0, nil
 	}
 
 	if Match(spec) == nil {

service/api/specs/splitversionfilter.go

@@ -13,7 +13,7 @@ func NewSplitVersionFilter() SplitVersionFilter {
 		FLAG_V1_1: {matchers.MatcherTypeInLargeSegment: true},
 	}
 
-	data[Default] = mergeMaps(map[string]bool{
+	data[FLAG_V1_0] = mergeMaps(map[string]bool{
 		matchers.MatcherEqualToSemver:                  true,
 		matchers.MatcherTypeLessThanOrEqualToSemver:    true,
 		matchers.MatcherTypeGreaterThanOrEqualToSemver: true,

service/api/specs/splitversionfilter_test.go

@@ -8,7 +8,7 @@ import (
 
 func TestParseAndValidate(t *testing.T) {
 	res, err := ParseAndValidate("")
-	if err != nil || res != Default {
+	if err != nil || res != FLAG_V1_0 {
 		t.Error("It should be 1.1")
 	}
 
@@ -30,12 +30,12 @@ func TestParseAndValidate(t *testing.T) {
 
 func TestSplitVersionFilter(t *testing.T) {
 	filter := NewSplitVersionFilter()
-	shouldFilter := filter.ShouldFilter(matchers.MatcherTypeBetweenSemver, Default)
+	shouldFilter := filter.ShouldFilter(matchers.MatcherTypeBetweenSemver, FLAG_V1_0)
 	if !shouldFilter {
 		t.Error("It should filtered")
 	}
 
-	shouldFilter = filter.ShouldFilter(matchers.MatcherTypeEqualTo, Default)
+	shouldFilter = filter.ShouldFilter(matchers.MatcherTypeEqualTo, FLAG_V1_0)
 	if shouldFilter {
 		t.Error("It should not filtered")
 	}
@@ -45,7 +45,7 @@ func TestSplitVersionFilter(t *testing.T) {
 		t.Error("It should not filtered")
 	}
 
-	shouldFilter = filter.ShouldFilter(matchers.MatcherTypeInLargeSegment, Default)
+	shouldFilter = filter.ShouldFilter(matchers.MatcherTypeInLargeSegment, FLAG_V1_0)
 	if !shouldFilter {
 		t.Error("It should filtered")
 	}