You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be super useful to have an integration test for this - I know it's fiddly because CLP can only be injected through hosting, but it would really help with confidence when changing things in the I/O subsystem.
get a builder w/ spin_engine::Builder::with_engine,
HttpTrigger::configure_execution_context,
builder.build()
get component_triggers from app,
HttpTrigger::new w/ all that,
.run() the http_trigger, and then
curl it to see the result of the .wasm module's println!s.
Are you suggesting recreating something like that in the integration tests? If not, how would you go about it?
Something like that would be great. Unfortunately the integration tests only have infrastructure for the normal Spin binary at the moment (via SpinTestController), so there's new infra to be built here. If you don't want to tackle that, raise an issue and I'll get onto it once this is merged. (And if you could share your existing manual test code in the issue, that would be a big timesaver!)
Hmmm~ I just don't know how much time I can afford to allocate there. SOOO... If that's ok then, I think I'll pass that onto you and help w/ reviewing.
This was referenced here: #482, and should be done after the PR is merged.
Here's a compilation of relevant comments:
The text was updated successfully, but these errors were encountered: