-
Notifications
You must be signed in to change notification settings - Fork 271
Support processing guest stdout/stderr through tracing
#449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Could we brainstorm the desired behaviour here? I'm not very familiar with the various tracing options. E.g.:
We can do this as a SIP or just figure out a general spec in this issue, but I'd like us to think about what we want before we dive into this! |
It should at least be optional at the engine level to support WAGI and any other triggers that need to process stdio. I think that it would otherwise make sense to pass all logging output through tracing, and handle log file/console output with subscribers.
Yes. I'd be inclined to default to
I think timestamps are handled by the subscriber. Application and component I would see as "spans" I don't think we need a SIP for this. We're already using |
This is subsumed by #520 |
In #431 we add support for copying guest output to the console. If we update that implementation to pass through
tracing
we would gain a nice way to hook in other log processing options.cc @itowlson
The text was updated successfully, but these errors were encountered: