Skip to content

Update URL component source cache to use configured root #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itowlson opened this issue Feb 22, 2023 · 1 comment
Closed

Update URL component source cache to use configured root #1188

itowlson opened this issue Feb 22, 2023 · 1 comment

Comments

@itowlson
Copy link
Collaborator

The URL component source cache PR (#1088) included the comment:

"TODO: when spin up integrates running an app from OCI, pass the configured cache root to this function. For now, use the default cache directory." (https://github.com/fermyon/spin/pull/1088/files/4d99bcf842d7e3e1166db8a43a438613e33b0090#r1098922615)

Now that spin up work has been done, we should check back on this and, if necessary, update URL source caching to use the configured cache root if there is one.

cc @fibonacci1729

@itowlson itowlson moved this to 🆕 Triage Needed in Spin Triage Feb 22, 2023
@itowlson itowlson moved this from 🆕 Triage Needed to 🔖 Backlog in Spin Triage Feb 22, 2023
@fibonacci1729 fibonacci1729 removed their assignment Mar 6, 2023
@itowlson
Copy link
Collaborator Author

I'm pretty sure this is done. #2377 is building on what's already there and it sure as heck looks like it's done. Closing: reopen if I'm wrong.

@github-project-automation github-project-automation bot moved this from 🔖 Backlog to ✅ Done in Spin Triage Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants