From 125d360ecef0b9416ab221aada7ab634efa42a16 Mon Sep 17 00:00:00 2001 From: Thorsten Hans Date: Wed, 8 Jan 2025 10:58:21 +0100 Subject: [PATCH] fix: use ParseInt instead of Atoi to prevent potential integer overflow Signed-off-by: Thorsten Hans --- internal/controller/shim_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/controller/shim_controller.go b/internal/controller/shim_controller.go index e6f9baa8..36beff75 100644 --- a/internal/controller/shim_controller.go +++ b/internal/controller/shim_controller.go @@ -463,7 +463,7 @@ func (sr *ShimReconciler) createJobManifest(shim *rcmv1.Shim, node *corev1.Node, } // set ttl for the installer job only if specified by the user if ttlStr := os.Getenv("SHIM_NODE_INSTALLER_JOB_TTL"); ttlStr != "" { - if ttl, err := strconv.Atoi(ttlStr); err == nil && ttl > 0 { + if ttl, err := strconv.ParseInt(ttlStr, 10, 32); err == nil && ttl > 0 { job.Spec.TTLSecondsAfterFinished = ptr(int32(ttl)) } }