You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@lan496 this should maybe be a pymatgen issue rather than a moyo issue but wanted to hear your opinion first.
after #80, i compared the maps from international number to HM short symbol you get from pymatgen and moyopy, expecting them to be identical but actually they differ for the monoclinic spacegroups. looks like pymatgen returns the full Hermann–Mauguin symbol for 3-15 and HM short else. not sure if this is by design and if so, why.
frompymatgen.symmetry.groupsimportSpaceGroupfrommoyopyimportSpaceGroupTypepmg_spg_map= {
number: SpaceGroup.from_int_number(number).symbolfornumberinrange(1, 230+1)
}
moyo_spg_map= {
# SpaceGroupType(number).hm_short is separated by a space like "F m -3 m"number: SpaceGroupType(number).hm_short.replace(" ", "")
fornumberinrange(1, 230+1)
}
forkinpmg_spg_map:
ifpmg_spg_map[k] !=moyo_spg_map[k]:
print(k, pmg_spg_map[k], moyo_spg_map[k])
# this prints3P121P24P12_11P2_15C121C26P1m1Pm7P1c1Pc8C1m1Cm9C1c1Cc10P12/m1P2/m11P12_1/m1P2_1/m12C12/m1C2/m13P12/c1P2/c14P12_1/c1P2_1/c15C12/c1C2/c
The text was updated successfully, but these errors were encountered:
@lan496 this should maybe be a
pymatgen
issue rather than amoyo
issue but wanted to hear your opinion first.after #80, i compared the maps from international number to HM short symbol you get from
pymatgen
andmoyopy
, expecting them to be identical but actually they differ for the monoclinic spacegroups. looks likepymatgen
returns the full Hermann–Mauguin symbol for 3-15 and HM short else. not sure if this is by design and if so, why.The text was updated successfully, but these errors were encountered: