Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moon hourly #3

Open
malipivo opened this issue Jan 23, 2021 · 4 comments
Open

Moon hourly #3

malipivo opened this issue Jan 23, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@malipivo
Copy link

Good day, just a tip: It'd be great to have an option of downloading Moon images even per hour as SVS NASA provides them.
Thank you for the package and best regards, Pavel

@spacerest spacerest added the enhancement New feature or request label Jan 23, 2021
@spacerest
Copy link
Owner

@malipivo Thanks for the request! I've been wondering what's the best way to go with this. I need to get my head around some timezone stuff and will give it a shot soon :)

@spacerest
Copy link
Owner

@malipivo I think this should work now on the most recent commit. Currently Moon.set_moon_phase(date="2021-01-01", hour=0) should get the first moon of the year and Moon.set_moon_phase(date="2021-12-31", hour=23) should get the last moon of the year.

I've written a few tests and will double check it again soon. Let me know if you get a chance to try it and notice any issues or have any thoughts on whether the date and hour parameters are straightforward enough.

@malipivo
Copy link
Author

Wow, you are fast! Thank you! 👍 I've tested it and it works as expected. At first use of your package, I expected date in the datetime format, not as string, but that's not a problem at all. I'm using straighforward str(mydate.strftime("%Y-%m-%d")).

@malipivo
Copy link
Author

malipivo commented Jan 24, 2021

One thought. It might be useful for some people to be able to download the original-sized pictures. And changing 1000 x 1000 pixels in resolution as an option, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants