Skip to content

Commit 65237a1

Browse files
author
Jeff Wendling
committed
error on invalid primary key definition
fixes #6
1 parent 864bbc8 commit 65237a1

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

syntax/parse_field_ref.go

+4
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ func parseRelativeFieldRefs(node *tupleNode) (*ast.RelativeFieldRefs, error) {
7474
return nil, err
7575
}
7676
if ref_token == nil {
77+
if len(refs.Refs) == 0 {
78+
return nil, errutil.New(node.getPos(),
79+
"must specify some field references")
80+
}
7781
return refs, nil
7882
}
7983
refs.Refs = append(refs.Refs, relativeFieldRefFromToken(ref_token))

syntax/parse_model.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414

1515
package syntax
1616

17-
import "gopkg.in/spacemonkeygo/dbx.v1/ast"
17+
import (
18+
"gopkg.in/spacemonkeygo/dbx.v1/ast"
19+
)
1820

1921
func parseModel(node *tupleNode) (*ast.Model, error) {
2022
model := new(ast.Model)

testdata/build/bad_key.dbx

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
//test:fail_gen must specify some field references
2+
3+
model foo (
4+
key
5+
field pk serial64
6+
)

0 commit comments

Comments
 (0)