Dropping upload issue

[Svist666s]

Load prototype is dropping if it is full valid, All proto that not type: entity and refers to other proto, that loading in one file will catch an error. For example, this will catch an error:

- type: entity
  id: VeryGoodTestThing
  name: good test thing
  description: It's cool
  parent: ClothingHeadHatCentcom

- type: latheRecipe
  id: VeryGoodTestRecipe
  result: VeryGoodTestThing
  completetime: 2
  applyMaterialDiscount: false
  materials:
    Steel: 100

Error text:

[ERRO] adminbus: Failed to load prototype data. Dropping upload.
Robust.Shared.Prototypes.PrototypeLoadException: Validation failed for Content.Shared.Research.Prototypes.LatheRecipePrototype(VeryGoodTestRecipe)
No EntityPrototype found with id VeryGoodTestThing
   at Robust.Shared.Prototypes.PrototypeManager.ValidatePrototype(Type kind, String id, MappingDataNode mapping, YamlValidationContext context) in C:\Users\Svist\Folder\serverSS14Official\space-station-14\RobustToolbox\Robust.Shared\Prototypes\PrototypeManager.cs:line 525
   at Robust.Shared.Prototypes.PrototypeManager.ReloadPrototypes(Dictionary`2 modified, Dictionary`2 removed, Boolean throwOnFailure) in C:\Users\Svist\Folder\serverSS14Official\space-station-14\RobustToolbox\Robust.Shared\Prototypes\PrototypeManager.cs:line 466
   at Robust.Shared.Prototypes.PrototypeManager.Robust.Shared.Prototypes.IPrototypeManagerInternal.ReloadPrototypesOrThrow(Dictionary`2 modified, Dictionary`2 removed) in C:\Users\Svist\Folder\serverSS14Official\space-station-14\RobustToolbox\Robust.Shared\Prototypes\PrototypeManager.cs:line 359
   at Robust.Shared.Upload.SharedPrototypeLoadManager.LoadPrototypeData(String data) in C:\Users\Svist\Folder\serverSS14Official\space-station-14\RobustToolbox\Robust.Shared\Upload\SharedPrototypeLoadManager.cs:line 67
   at Robust.Shared.Upload.SharedPrototypeLoadManager.TryLoadPrototypeData(String data) in C:\Users\Svist\Folder\serverSS14Official\space-station-14\RobustToolbox\Robust.Shared\Upload\SharedPrototypeLoadManager.cs:line 46

Some proto that loaded without any changes, except id field and will cause an error:

- type: entity
  parent: [ ClothingHeadHardsuitBase, ClothingHeadSuitWithLightBase ]
  id: ClothingHeadHelmetHardsuitSpatioTEST
  name: spationaut hardsuit helmet
  description: A sturdy helmet designed for complex industrial operations in space.
  components:
  - type: Sprite
    sprite: Clothing/Head/Hardsuits/spatiohelm.rsi
  - type: HandheldLight
    addPrefix: false
  - type: PointLight
    radius: 6
  - type: PressureProtection
    highPressureMultiplier: 0.72
    lowPressureMultiplier: 1000
  - type: Tag
    tags:
    - WhitelistChameleon

Dropping upload appeared in #6548 and if you locally revert this all will be fine,
Now only way to load big proto is to separate it in 3 or 4 files. It's horrible.

And I want to note that this problem was noticed on the fork and checked on Wizden repo.
We (fork admems) would be very happy if #6548 will be reverted for the rework )

[sleepyyapril]

I don't think reverting something that is caused by a separate issue is the way to go about it. It is the validation doing its job in that the entity prototype doesn't technically exist yet.

The solution is not three or four files, it's two. One with all entities in relation to your lathe recipes, and two with your lathe recipes. I tested it, and this works. Maybe the validation should validate, read, and load one prototype at a time to solve this issue, but it's nowhere near as big of an issue as you think.

[Svist666s]

I don't think reverting something that is caused by a separate issue is the way to go about it. It is the validation doing its job in that the entity prototype doesn't technically exist yet.

The solution is not three or four files, it's two. One with all entities in relation to your lathe recipes, and two with your lathe recipes. I tested it, and this works. Maybe the validation should validate, read, and load one prototype at a time to solve this issue, but it's nowhere near as big of an issue as you think.

Recipes that refers to other recipes dropping to
It's very bad for big admem proto

[sleepyyapril]

Recipes that refers to other recipes dropping to It's very bad for big admem proto

Use a folder, but it's correctly validating because they don't exist.

[Svist666s]

Folder for yml files, that must be loaded one by one... Disgusting
It doesn't matter whether it's right or wrong validation, this is not good for admem prototypes

[sleepyyapril]

Folder for yml files, that must be loaded one by one... Disgusting It doesn't matter whether it's right or wrong validation, this is not good for admem prototypes

there is literally a "load folder" command