feat(s3): bucket versioning XML

Author: sowahq

internal/api/s3/handlers.go

@@ -112,6 +112,9 @@ func handleCreateBucket(c *fiber.Ctx) error {
 	if c.Request().URI().QueryArgs().Has("object-lock") {
 		return handlePutBucketObjectLock(c)
 	}
+	if c.Request().URI().QueryArgs().Has("versioning") {
+		return handlePutBucketVersioning(c)
+	}
 
 	name := c.Params("bucket")
 
@@ -571,6 +574,9 @@ func handleListObjectsV2(c *fiber.Ctx) error {
 	if c.Request().URI().QueryArgs().Has("versions") {
 		return handleListObjectVersions(c)
 	}
+	if c.Request().URI().QueryArgs().Has("versioning") {
+		return handleGetBucketVersioning(c)
+	}
 
 	name := c.Params("bucket")
 

internal/api/s3/versioning.go

@@ -0,0 +1,65 @@
+package s3
+
+import (
+	"encoding/xml"
+
+	"github.com/anhostfr/hangar/internal/service/auth"
+	"github.com/anhostfr/hangar/internal/service/bucket"
+	"github.com/gofiber/fiber/v2"
+)
+
+func handleGetBucketVersioning(c *fiber.Ctx) error {
+	name := c.Params("bucket")
+	if !hasPerm(c, auth.PermRead) || !keyAllowsBucket(c, name) {
+		return writeError(c, fiber.StatusForbidden, "AccessDenied", "Access denied", "/"+name)
+	}
+
+	info, err := bucket.GetBucket(name)
+	if err != nil {
+		return writeError(c, fiber.StatusNotFound, "NoSuchBucket", err.Error(), "/"+name)
+	}
+
+	out := VersioningConfigurationXML{Xmlns: xmlNamespace}
+	if info.VersioningEnabled {
+		out.Status = "Enabled"
+	}
+
+	return writeXML(c, fiber.StatusOK, out)
+}
+
+func handlePutBucketVersioning(c *fiber.Ctx) error {
+	name := c.Params("bucket")
+	if !hasPerm(c, auth.PermWrite) || !keyAllowsBucket(c, name) {
+		return writeError(c, fiber.StatusForbidden, "AccessDenied", "Access denied", "/"+name)
+	}
+
+	if _, err := bucket.GetBucket(name); err != nil {
+		return writeError(c, fiber.StatusNotFound, "NoSuchBucket", err.Error(), "/"+name)
+	}
+
+	body := c.Body()
+	if len(body) == 0 {
+		return writeError(c, fiber.StatusBadRequest, "MalformedXML", "empty versioning body", "/"+name)
+	}
+
+	var in VersioningConfigurationXML
+	if err := xml.Unmarshal(body, &in); err != nil {
+		return writeError(c, fiber.StatusBadRequest, "MalformedXML", err.Error(), "/"+name)
+	}
+
+	var enabled bool
+	switch in.Status {
+	case "Enabled":
+		enabled = true
+	case "Suspended":
+		enabled = false
+	default:
+		return writeError(c, fiber.StatusBadRequest, "IllegalVersioningConfigurationException", "invalid Status: must be Enabled or Suspended", "/"+name)
+	}
+
+	if _, err := bucket.UpdateVersioning(name, enabled); err != nil {
+		return writeError(c, fiber.StatusInternalServerError, "InternalError", err.Error(), "/"+name)
+	}
+
+	return c.SendStatus(fiber.StatusOK)
+}

internal/api/s3/versioning_test.go

@@ -0,0 +1,71 @@
+package s3
+
+import (
+	"encoding/xml"
+	"io"
+	"net/http"
+	"testing"
+
+	"github.com/anhostfr/hangar/internal/service/bucket"
+)
+
+func TestS3BucketVersioningXML(t *testing.T) {
+	s := newS3TestServer(t)
+	if _, err := bucket.CreateBucket(&bucket.CreateBucketRequest{Name: "vxb"}); err != nil {
+		t.Fatalf("bucket: %v", err)
+	}
+
+	resp := s.do(t, http.MethodGet, "/vxb", "versioning=", nil)
+	body, _ := io.ReadAll(resp.Body)
+	resp.Body.Close()
+	if resp.StatusCode != http.StatusOK {
+		t.Fatalf("get initial: %d", resp.StatusCode)
+	}
+	var got VersioningConfigurationXML
+	if err := xml.Unmarshal(body, &got); err != nil {
+		t.Fatalf("decode: %v", err)
+	}
+	if got.Status != "" {
+		t.Fatalf("expected empty status before enabling, got %q", got.Status)
+	}
+
+	putBody := []byte(`<VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Status>Enabled</Status></VersioningConfiguration>`)
+	resp = s.do(t, http.MethodPut, "/vxb", "versioning=", putBody)
+	resp.Body.Close()
+	if resp.StatusCode != http.StatusOK {
+		t.Fatalf("put enable: %d", resp.StatusCode)
+	}
+
+	info, err := bucket.GetBucket("vxb")
+	if err != nil || !info.VersioningEnabled {
+		t.Fatalf("expected versioning enabled in storage, info=%+v err=%v", info, err)
+	}
+
+	resp = s.do(t, http.MethodGet, "/vxb", "versioning=", nil)
+	body, _ = io.ReadAll(resp.Body)
+	resp.Body.Close()
+	if err := xml.Unmarshal(body, &got); err != nil {
+		t.Fatalf("decode after enable: %v", err)
+	}
+	if got.Status != "Enabled" {
+		t.Fatalf("status=%q want Enabled", got.Status)
+	}
+
+	putBody = []byte(`<VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Status>Suspended</Status></VersioningConfiguration>`)
+	resp = s.do(t, http.MethodPut, "/vxb", "versioning=", putBody)
+	resp.Body.Close()
+	if resp.StatusCode != http.StatusOK {
+		t.Fatalf("put suspend: %d", resp.StatusCode)
+	}
+	info, _ = bucket.GetBucket("vxb")
+	if info.VersioningEnabled {
+		t.Fatalf("expected versioning disabled after Suspended")
+	}
+
+	putBody = []byte(`<VersioningConfiguration><Status>Bogus</Status></VersioningConfiguration>`)
+	resp = s.do(t, http.MethodPut, "/vxb", "versioning=", putBody)
+	resp.Body.Close()
+	if resp.StatusCode != http.StatusBadRequest {
+		t.Fatalf("expected 400 for bogus status, got %d", resp.StatusCode)
+	}
+}

website/src/content/docs/s3-compatibility.md

@@ -35,7 +35,7 @@ Configure SDKs with `UsePathStyle: true` (Go SDK v2), `s3={"addressing_style":"p
 | `GetBucketLocation`                          | ❌     | Returns the server's configured `region` implicitly through SigV4 |
 | `GetBucketAcl` / `PutBucketAcl`              | ❌     |                                                      |
 | `GetBucketPolicy` / `PutBucketPolicy`        | ❌     |                                                      |
-| `GetBucketVersioning` / `PutBucketVersioning`| ❌     | Versioning is toggled via the native admin API       |
+| `GetBucketVersioning` / `PutBucketVersioning`| ✅     | `VersioningConfiguration` XML with `Status: Enabled` / `Suspended`     |
 | `GetBucketTagging` / `PutBucketTagging`      | ❌     |                                                      |
 | `GetBucketLogging` / `PutBucketLogging`      | ❌     |                                                      |
 | `GetBucketCors` / `PutBucketCors` / `DeleteBucketCors` | ✅ | See [CORS](/operations/cors/)                  |