Skip to content

Commit 93bb48c

Browse files
authored
Merge pull request #46 from sourceplusplus/dev
Dev
2 parents 621620b + 6036e32 commit 93bb48c

File tree

7 files changed

+8
-16
lines changed

7 files changed

+8
-16
lines changed

control/build.gradle.kts

+3-5
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ tasks.getByName<JavaCompile>("compileJava") {
2525
dependencies {
2626
compileOnly("org.apache.skywalking:apm-agent-core:$skywalkingAgentVersion")
2727
implementation("io.vertx:vertx-tcp-eventbus-bridge:$vertxVersion")
28-
implementation("com.fasterxml.jackson.core:jackson-databind:$jacksonVersion")
2928
implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:$jacksonVersion")
3029
implementation("com.github.sourceplusplus.protocol:protocol:$projectVersion") {
3130
isTransitive = false
@@ -41,10 +40,6 @@ dependencies {
4140
testImplementation("io.vertx:vertx-service-proxy:$vertxVersion")
4241
testImplementation("io.vertx:vertx-service-discovery:$vertxVersion")
4342
testImplementation("io.vertx:vertx-lang-kotlin-coroutines:$vertxVersion")
44-
testImplementation("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:$jacksonVersion")
45-
testImplementation("com.fasterxml.jackson.datatype:jackson-datatype-jdk8:$jacksonVersion")
46-
testImplementation("com.fasterxml.jackson.datatype:jackson-datatype-guava:$jacksonVersion")
47-
testImplementation("com.fasterxml.jackson.module:jackson-module-kotlin:$jacksonVersion")
4843
}
4944

5045
tasks.getByName<Test>("test") {
@@ -148,5 +143,8 @@ tasks.getByName<com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar>("sha
148143
relocate("org.yaml", "spp.probe.common.org.yaml")
149144
relocate("io", "spp.probe.common.io")
150145
relocate("com.fasterxml", "spp.probe.common.com.fasterxml")
146+
147+
//need to move marshall package to allow probe to observe platform
148+
relocate("spp.protocol.marshall", "spp.protocol")
151149
}
152150
tasks.getByName("jar").dependsOn("shadowJar")

control/src/main/kotlin/spp/probe/control/LiveInstrumentRemote.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import org.apache.skywalking.apm.agent.core.context.util.ThrowableTransformer
2626
import org.apache.skywalking.apm.agent.core.plugin.WitnessFinder
2727
import spp.probe.ProbeConfiguration
2828
import spp.probe.SourceProbe
29-
import spp.protocol.ProtocolMarshaller
29+
import spp.protocol.marshall.ProtocolMarshaller
3030
import spp.protocol.instrument.*
3131
import spp.protocol.instrument.command.CommandType
3232
import spp.protocol.instrument.command.LiveInstrumentCommand

control/src/main/resources/build.properties

-5
This file was deleted.

control/src/test/kotlin/integration/LiveBreakpointTest.kt renamed to control/src/test/kotlin/integration/ProbeBreakpointTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import spp.protocol.instrument.event.LiveInstrumentEvent
3333
import spp.protocol.instrument.event.LiveInstrumentEventType
3434
import java.util.concurrent.TimeUnit
3535

36-
class LiveBreakpointTest : ProbeIntegrationTest() {
36+
class ProbeBreakpointTest : ProbeIntegrationTest() {
3737

3838
@Test
3939
fun testPrimitives() = runBlocking {

control/src/test/kotlin/integration/ProbeIntegrationTest.kt

+1-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.BeforeAll
3636
import org.junit.jupiter.api.extension.ExtendWith
3737
import org.slf4j.Logger
3838
import org.slf4j.LoggerFactory
39-
import spp.protocol.ProtocolMarshaller
39+
import spp.protocol.marshall.ProtocolMarshaller
4040
import spp.protocol.SourceServices
4141
import spp.protocol.SourceServices.Provide.toLiveInstrumentSubscriberAddress
4242
import spp.protocol.extend.TCPServiceFrameParser
@@ -68,7 +68,6 @@ abstract class ProbeIntegrationTest {
6868
@JvmStatic
6969
fun setup() = runBlocking {
7070
vertx = Vertx.vertx()
71-
ProtocolMarshaller.setupCodecs(vertx)
7271

7372
val socket = setupTcp(vertx)
7473
socket.handler(FrameParser(TCPServiceFrameParser(vertx, socket)))

control/src/test/kotlin/integration/LiveLogTest.kt renamed to control/src/test/kotlin/integration/ProbeLogTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import spp.protocol.instrument.event.LiveInstrumentEventType
3333
import spp.protocol.instrument.event.LiveLogHit
3434
import java.util.concurrent.TimeUnit
3535

36-
class LiveLogTest : ProbeIntegrationTest() {
36+
class ProbeLogTest : ProbeIntegrationTest() {
3737

3838
@Test
3939
fun testPrimitives() = runBlocking {

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
kotlin.code.style=official
22

33
probeGroup=spp.probe
4-
projectVersion=0.4.1
4+
projectVersion=0.4.2
55

66
vertxVersion=4.2.4
77

0 commit comments

Comments
 (0)