Skip to content

Commit 852899c

Browse files
committed
refactor: typed live instrument events
1 parent 17000ea commit 852899c

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/main/kotlin/spp/cli/commands/developer/instrument/SubscribeInstrument.kt

+9-9
Original file line numberDiff line numberDiff line change
@@ -88,27 +88,27 @@ class SubscribeInstrument : CliktCommand(
8888
socket!!.handler(FrameParser(TCPServiceFrameParser(vertx, socket)))
8989

9090
vertx.eventBus().consumer<JsonObject>(toLiveInstrumentSubscriberAddress(PlatformCLI.developer.id)) {
91-
val liveEvent = LiveInstrumentEvent(it.body())
91+
val liveEvent = LiveInstrumentEvent.fromJson(it.body())
9292

9393
//todo: impl filter on platform
9494
if (instrumentIds.isNotEmpty()) {
9595
when (liveEvent.eventType) {
9696
LiveInstrumentEventType.LOG_HIT -> {
97-
val logHit = LiveLogHit(JsonObject(liveEvent.data))
97+
val logHit = liveEvent as LiveLogHit
9898
if (logHit.logId !in instrumentIds) {
9999
return@consumer
100100
}
101101
}
102102

103103
LiveInstrumentEventType.BREAKPOINT_HIT -> {
104-
val breakpointHit = LiveBreakpointHit(JsonObject(liveEvent.data))
104+
val breakpointHit = liveEvent as LiveBreakpointHit
105105
if (breakpointHit.breakpointId !in instrumentIds) {
106106
return@consumer
107107
}
108108
}
109109

110110
LiveInstrumentEventType.BREAKPOINT_REMOVED, LiveInstrumentEventType.LOG_REMOVED -> {
111-
val logRemoved = LiveInstrumentRemoved(JsonObject(liveEvent.data))
111+
val logRemoved = liveEvent as LiveInstrumentRemoved
112112
if (logRemoved.liveInstrument.id !in instrumentIds) {
113113
return@consumer
114114
}
@@ -120,18 +120,18 @@ class SubscribeInstrument : CliktCommand(
120120

121121
if (!includeBreakpoints && !includeLogs && !includeMeters && !includeTraces) {
122122
//listen for all events
123-
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.data}")
123+
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.toJson()}")
124124
} else {
125125
//todo: impl filtering on platform
126126
//listen for specific events
127127
if (includeBreakpoints && liveEvent.eventType.name.startsWith("breakpoint", true)) {
128-
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.data}")
128+
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.toJson()}")
129129
} else if (includeLogs && liveEvent.eventType.name.startsWith("log", true)) {
130-
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.data}")
130+
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.toJson()}")
131131
} else if (includeMeters && liveEvent.eventType.name.startsWith("meter", true)) {
132-
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.data}")
132+
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.toJson()}")
133133
} else if (includeTraces && liveEvent.eventType.name.startsWith("trace", true)) {
134-
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.data}")
134+
println("\nType: ${liveEvent.eventType}\nData: ${liveEvent.toJson()}")
135135
}
136136
}
137137
}

0 commit comments

Comments
 (0)