Support removing rules by name from the schema transformer (#1590)

Signed-off-by: Juan Cruz Viotti <[email protected]>

Author: jviotti

src/core/jsonschema/include/sourcemeta/core/jsonschema_transform.h

@@ -198,6 +198,9 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaTransformer {
     this->rules.emplace(rule->name(), std::move(rule));
   }
 
+  /// Remove a rule from the bundle
+  auto remove(const std::string &name) -> bool;
+
   /// Apply the bundle of rules to a schema
   auto
   apply(JSON &schema, const SchemaWalker &walker,

src/core/jsonschema/transformer.cc

@@ -138,6 +138,10 @@ auto SchemaTransformer::apply(
   }
 }
 
+auto SchemaTransformer::remove(const std::string &name) -> bool {
+  return this->rules.erase(name) > 0;
+}
+
 auto SchemaTransformer::check(
     const JSON &schema, const SchemaWalker &walker,
     const SchemaResolver &resolver,

test/jsonschema/jsonschema_transformer_test.cc

@@ -539,3 +539,31 @@ TEST(JSONSchema_transformer, check_with_default_dialect) {
   EXPECT_EQ(std::get<1>(entries.at(1)), "example_rule_2");
   EXPECT_EQ(std::get<2>(entries.at(1)), "Keyword bar is not permitted");
 }
+
+TEST(JSONSchema_transformer, remove_rule_by_name) {
+  sourcemeta::core::SchemaTransformer bundle;
+  bundle.add<ExampleRule1>();
+  bundle.add<ExampleRule2>();
+
+  sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "foo": "bar",
+    "bar": "baz",
+    "qux": "xxx"
+  })JSON");
+
+  EXPECT_TRUE(bundle.remove("example_rule_2"));
+  EXPECT_FALSE(bundle.remove("example_rule_2"));
+  EXPECT_FALSE(bundle.remove("i_dont_exist"));
+
+  bundle.apply(document, sourcemeta::core::schema_official_walker,
+               sourcemeta::core::schema_official_resolver);
+
+  const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "bar": "baz",
+    "qux": "xxx"
+  })JSON");
+
+  EXPECT_EQ(document, expected);
+}