"Configure external services to connect repositories to Sourcegraph" does not go away after configuring external services

[emidoots]

A user onboarding noted this alert at the top of the page would not go away:

Configure external services to connect repositories to Sourcegraph

After a few seconds he realized it was dismissible, but this is a nasty UX

[attfarhan]

@slimsag I am not able to repro on a fresh instance, do you have additional details on this? If you remember, how was the external service configured?

[attfarhan]

Ok I think I found a repro. Can you verify this is the case he ran into?:

• On a fresh instance, add a new external service.
• Specify orgs, but don't add an access token.
• Save the external service.
• Correctly see a 401 error.
• Edit the external service, add an access token, and save.
• Notice the banner doesn't go away.

[emidoots]

That sounds correct to me

On Tue, Feb 25, 2020 at 10:13 PM Farhan Attamimi ***@***.***> wrote: Ok I think I found a repro. Can you verify this is the case he ran into?: - On a fresh instance, add a new external service. - Specify orgs, but don't add an access token. - Save the external service. - Correctly see a 401 error. - Edit the external service, add an access token, and save. - Notice the banner doesn't go away. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <sourcegraph/sourcegraph#7590>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYGWOA6N3ZAG7W356WA3J3REX27DANCNFSM4KEQOHEQ> .

-- Follow me on twitter @slimsag <https://twitter.com/slimsag>.