Enter Sourcegraph search query directly from VS Code command menu

[jjinnii]

Feature request description

Ability to enter a search query from VS Code command menu. CMD + Shift + P -> Sourcegraph: search query.

As a user, if I would like to perform a Sourcegraph search but do not already have a Sourcegraph search tab open, it is an extra step for me to click on the Sourcegraph icon in the toolbar before being able to perform a search. VS Code users are also accustomed to using VS Code commands to quickly perform tasks (especially for extensions), and this may be a gut first step for many of our users.

Additional context

This is taken from internal feedback.

Technical considerations

Are we able to implement auto complete in the VS Code command menu as a user completes a search?

[tjkandala]

I initially removed this feature, which exists in the legacy extension, precisely because we can't autocomplete search filters, so I believed that users would rather use the real input box.

However, this feedback makes a lot of sense. We can't have a fully-featured input box, but we can use the QuickPick API to perhaps show the user's previous searches as well as let them enter a new search query. Would that be good enough?

[jjinnii]

Thanks for the context @tjkandala! Just for my understanding, when you say "let them enter a new search query", we wouldn't offer auto-complete, but could a user at least fully type out Sourcegraph syntax? (i.e. repo: wouldn't autocomplete, but a user can type the full syntax out and maybe we could at least color code?)

[tjkandala]

@jjinnii I think it's more along the lines of they can type the syntax out but without highlighting, unfortunately.

However, I just realized that users can just execute the search command in the VS Code command palette which will open or focus the panel... and that's the same number of steps as adding a command that opens a stunted input box.

We also have keyboard shortcuts to open the search panel

[jjinnii]

However, I just realized that users can just execute the search command in the VS Code command palette which will open or focus the panel

Search command meaning ">Sourcegraph: open search tab" right? Totally agree that that resolves most of the user problem I outlined, this is just a nice to have request that I wanted to document, but sounds like it's technically difficult to implement.

Also to clarify, this is not important/prioritized for first release! I am just documenting feature requests from internal feedback so we have them tracked, but they need to be prioritized. :)

cc: @tjkandala

[abeatrix]

@jjinnii Looks like this issue is related to https://github.com/sourcegraph/sourcegraph/issues/30267
Do you think this should be something we can tackle this sprint, or should we wait for more feedback to move forward with both issues?

[jjinnii]

Hey @abeatrix! This issue is specific to the VS Code command palette (cmd + shift + p), whereas issue #30267 is much more exploratory to somehow performing a Sourcegraph search in-line to your code blob or maybe even sidebar when you're in file view.

I think a great start would be if we could have a quick technical prototype for this ability to perform a search query in the command palette and then test it. Based on my earlier messages with @tjkandala, it seems like the effort is not high, but just heavily constrained (no autocomplete, syntax highlighting, etc.), so we should test whether this provides value towards #34346.

Let me know if that makes sense, and whether you could provide some ballpark estimate!

cc: @ryankscott

[abeatrix]

@jjinnii see video for a quick prototype:https://www.loom.com/share/14fcf7b42a1344a9b2c517576c86196b

As for https://github.com/sourcegraph/sourcegraph/issues/30267, is there anything we will need to do in this iteration? I will be on leave next week so want to see if we should move it to the next iteration and what needs to be done for it, thanks!