chore(deps): update dependency @sourcegraph/eslint-config to ^0.19.15 (#68)

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Felix Becker <[email protected]>

Author: 3 people

.eslintrc.json

@@ -5,6 +5,7 @@
   },
   "rules": {
     "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-unused-vars": "off",
     "@typescript-eslint/require-await": "off"
   }

.prettierignore

@@ -1,3 +1,4 @@
 package.json
 package-lock.json
 dist/
+.nyc_output/

.vscode/tasks.json

@@ -12,5 +12,12 @@
         "runOn": "folderOpen",
       },
     },
+    {
+      "type": "npm",
+      "script": "eslint",
+      "problemMatcher": ["$eslint-stylish"],
+      "label": "npm: eslint",
+      "detail": "eslint './src/*.ts?(x)'",
+    },
   ],
 }

package.json

@@ -49,7 +49,7 @@
   "devDependencies": {
     "@commitlint/cli": "^9.0.1",
     "@commitlint/config-conventional": "^9.0.1",
-    "@sourcegraph/eslint-config": "^0.16.3",
+    "@sourcegraph/eslint-config": "^0.19.15",
     "@sourcegraph/prettierrc": "^3.0.3",
     "@sourcegraph/tsconfig": "^4.0.1",
     "@types/mocha": "7.0.2",

src/api.test.ts

@@ -42,8 +42,11 @@ describe('createStubSourcegraphAPI()', () => {
         it('should allow registering a hover provider', () => {
             const stub = createStubSourcegraphAPI()
             stub.languages.registerHoverProvider(['*.ts'], {
-                provideHover: (doc, pos) => ({
-                    contents: { kind: stub.MarkupKind.Markdown, value: `${doc.uri}:${pos.line}:${pos.character}` },
+                provideHover: (textDocument, position) => ({
+                    contents: {
+                        kind: stub.MarkupKind.Markdown,
+                        value: `${textDocument.uri}:${position.line}:${position.character}`,
+                    },
                     range: new stub.Range(new stub.Position(1, 2), new stub.Position(3, 4)),
                 }),
             })

src/api.ts

@@ -11,7 +11,7 @@ import { BehaviorSubject, Subject, Subscription } from 'rxjs'
 import { mapTo } from 'rxjs/operators'
 import * as sinon from 'sinon'
 import * as sourcegraph from 'sourcegraph'
-import { notImplemented, subTypeOf } from './util'
+import { notImplemented, subtypeOf } from './util'
 
 let decorationTypeCounter = 0
 
@@ -23,7 +23,7 @@ export const createStubSourcegraphAPI = () => {
     const configSubject = new BehaviorSubject<any>({})
     const rootChanges = new Subject<void>()
     const openedTextDocuments = new Subject<sourcegraph.TextDocument>()
-    const stubs = subTypeOf<typeof import('sourcegraph')>()({
+    const stubs = subtypeOf<typeof import('sourcegraph')>()({
         // Classes
         URI: URL,
         Position,
@@ -87,7 +87,7 @@ export const createStubSourcegraphAPI = () => {
 
             registerViewProvider: sinon.spy((id: string, provider: sourcegraph.ViewProvider) => new Subscription()),
 
-            createDecorationType: () => ({ key: 'decorationType' + decorationTypeCounter++ }),
+            createDecorationType: () => ({ key: `decorationType${decorationTypeCounter++}` }),
             createPanelView: notImplemented as (id: string) => sourcegraph.PanelView,
         },
         configuration: Object.assign(configSubject.pipe(mapTo(undefined)), {

src/codeEditor.ts

@@ -1,13 +1,13 @@
 import { BehaviorSubject } from 'rxjs'
 import * as sinon from 'sinon'
 import * as sourcegraph from 'sourcegraph'
-import { subTypeOf } from './util'
+import { subtypeOf } from './util'
 
 export const createStubCodeEditor = ({
     document,
     selections = [],
 }: Pick<sourcegraph.CodeEditor, 'document'> & Partial<Pick<sourcegraph.CodeEditor, 'selections'>>) => {
-    const codeEditor = subTypeOf<sourcegraph.CodeEditor>()({
+    const codeEditor = subtypeOf<sourcegraph.CodeEditor>()({
         type: 'CodeEditor' as const,
         document,
         get selections(): sourcegraph.Selection[] {

src/context.test.ts

@@ -3,12 +3,12 @@ import { createStubExtensionContext } from './context'
 
 describe('createStubExtensionContext()', () => {
     it('should create an extension context', () => {
-        const ctx = createStubExtensionContext()
-        const fn = sinon.spy()
-        ctx.subscriptions.add(fn)
-        sinon.assert.notCalled(fn)
-        sinon.assert.calledOnce(ctx.subscriptions.add)
-        ctx.subscriptions.unsubscribe()
-        sinon.assert.calledOnce(fn)
+        const context = createStubExtensionContext()
+        const cleanup = sinon.spy(() => {})
+        context.subscriptions.add(cleanup)
+        sinon.assert.notCalled(cleanup)
+        sinon.assert.calledOnce(context.subscriptions.add)
+        context.subscriptions.unsubscribe()
+        sinon.assert.calledOnce(cleanup)
     })
 })

src/context.ts

@@ -1,14 +1,14 @@
 import { Subscription } from 'rxjs'
 import * as sinon from 'sinon'
 import { ExtensionContext } from 'sourcegraph'
-import { subTypeOf } from './util'
+import { subtypeOf } from './util'
 
 export const createStubExtensionContext = () => {
     const subscriptions = sinon.stub(new Subscription())
     subscriptions.add.callThrough()
     subscriptions.remove.callThrough()
     subscriptions.unsubscribe.callThrough()
-    const context = subTypeOf<ExtensionContext>()({
+    const context = subtypeOf<ExtensionContext>()({
         subscriptions,
     })
     return context

src/textDocument.ts

@@ -1,13 +1,13 @@
 import * as sinon from 'sinon'
 import * as sourcegraph from 'sourcegraph'
-import { notImplemented, subTypeOf } from './util'
+import { notImplemented, subtypeOf } from './util'
 
 /**
  * Creates a stub TextDocument.
  *
  */
 export const createStubTextDocument = (init: Pick<sourcegraph.TextDocument, 'languageId' | 'text' | 'uri'>) => {
-    const textDocument = subTypeOf<sourcegraph.TextDocument>()({
+    const textDocument = subtypeOf<sourcegraph.TextDocument>()({
         ...init,
         // TODO share the implementation of these methods with the real implementations
         getWordRangeAtPosition: sinon.spy<(position: sourcegraph.Position) => sourcegraph.Range | undefined>(

src/util.ts

@@ -4,7 +4,8 @@
  * @template U The type to check for (explicitly specify this)
  * @template T The actual type (inferred, don't specify this)
  */
-export const subTypeOf = <U>() => <T extends U>(value: T): T => value
+// eslint-disable-next-line unicorn/consistent-function-scoping
+export const subtypeOf = <U>() => <T extends U>(value: T): T => value
 
 export function notImplemented(): never {
     throw new Error('Stub functionality not implemented')