From 4a503be6e1860c155f2e87aea9352f73d7f4ff83 Mon Sep 17 00:00:00 2001
From: elad-c <elad.cohen@sony.com>
Date: Tue, 21 Jan 2025 15:50:36 +0200
Subject: [PATCH] fix
---
.../common/mixed_precision/solution_refinement_procedure.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/model_compression_toolkit/core/common/mixed_precision/solution_refinement_procedure.py b/model_compression_toolkit/core/common/mixed_precision/solution_refinement_procedure.py
index 76a090d6e..28936f116 100644
--- a/model_compression_toolkit/core/common/mixed_precision/solution_refinement_procedure.py
+++ b/model_compression_toolkit/core/common/mixed_precision/solution_refinement_procedure.py
@@ -139,8 +139,9 @@ def _get_valid_candidates_indices(node_candidates: List[CandidateNodeQuantizatio
activation_num_bits = current_candidate.activation_quantization_cfg.activation_n_bits
# Filter candidates that have higher bit-width for both weights and activations (except for the current index).
+ # TODO: activation bits comparison: should be >= if ACTIVATION or TOTAL ru is used. else should be ==.
return [i for i, c in enumerate(node_candidates) if
- c.activation_quantization_cfg.activation_n_bits >= activation_num_bits
+ c.activation_quantization_cfg.activation_n_bits == activation_num_bits
and c.weights_quantization_cfg.get_attr_config(kernel_attr).weights_n_bits >= weights_num_bits
and not (c.activation_quantization_cfg.activation_n_bits == activation_num_bits
and c.weights_quantization_cfg.get_attr_config(kernel_attr).weights_n_bits == weights_num_bits)]