Skip to content

Conversation

@nakano-omw
Copy link

OpenConfig support for Platform Transceiver.

sonic-net/SONiC#1858

Add support for following features:

  • serial-no
  • connector-type
  • vendor
  • vendor-part
  • date-code
  • supply-voltage
  • laser-temperature
  • output-power
  • input-power
  • laser-bias-current

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Signed-off-by: Kanji Nakano <[email protected]>
@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nakano-omw
Copy link
Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 160 in repo sonic-net/sonic-mgmt-common

@nakano-omw
Copy link
Author

/azp run Azure.sonic-mgmt-common

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 160 in repo sonic-net/sonic-mgmt-common

@nakano-omw
Copy link
Author

/azpw run Azure.sonic-mgmt-common\

@mssonicbld
Copy link

/AzurePipelines run Azure.sonic-mgmt-common\

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@hdwhdw hdwhdw requested review from judyjoseph and vvolam October 17, 2025 22:40
@hdwhdw
Copy link

hdwhdw commented Oct 17, 2025

@judyjoseph @vvolam are you the right (platform) person to review this?

@vvolam
Copy link

vvolam commented Oct 17, 2025

@hdwhdw @prgeor is the right person for xcvr.

@hdwhdw hdwhdw requested a review from prgeor October 17, 2025 23:21
Copy link

@anders-nexthop anders-nexthop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow each file in the review is showing up as being modified, even though there appears to be no difference to much of the file. Has the whitespace been changed perhaps? Can you figure out what was different and revert it, so that only actual changes show up in the diff here? It's really difficult to review as it is now, as there's no way to see what has the actual changes are.

@nakano-omw
Copy link
Author

@anders-nexthop Thanks for your feedback. It seems the whitespace or encoding differences caused unnecessary diffs. I’ll recreate the PR with only the actual changes — sorry for the trouble.

@nakano-omw
Copy link
Author

Hi @anders-nexthop,
I’ve created a new PR (#197) with the whitespace issues fixed so that only the actual changes appear in the diff. Could you please review it when you have a moment? Thanks again for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants