Added documentation directory, added instructions for creating a working .app on macOS (with needed scripts), and added macOS icon #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added instructions for generating a .app package for GModCEFCodecFix, as well as a directory to drop other documentation into.
Added launcher.sh, a proxy for running the Terminal version of GModCEFCodecFix inside of a .app package.
Generates a .app package from a shell script; Source: https://gist.github.com/mathiasbynens/674099
Fixed missing file extension for appgen instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly resolves #3 but does not yet codesign the .app package. I remove the codesign generated by pyinstaller for now because we're modifying the .app package after signing it. This probably isn't a necessary step but does prevent potential issues.
The documentation directory felt like a good idea and a good place to put all that that's out of the way but still accessible.
Thanks for looking :)