-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 721A token option #198
Comments
Do you mind enumerating the features included in ERC721A? I've never used it before. Is it fully compliant with ERC721? |
ERC721A is a gas optimized ERC721 implementation originally created by Azuki to minimize batch minting costs. It's a fully compliant ERC721, it's just optimized a little differently than the OZ implementation which most people base theirs off of. |
Okay, I need a list of specific features and changes, in order to determine which path makes most sense:
In general, SS aims for composability (as far as inheritance will allow), so we need to look at how well the individual optimizations can be added as discrete features, and what fundamental compromises they entail. |
ERC721A is functionally the same as ERC721A but with a batch mint that uses roughly the same amount of gas as a singular mint. It would make the most sense as a ERC721 Extension in this repository I would think. Incase someone had a use case for it. But open to your feedback on that. |
I was wondering if anyone would be interested in having a choice between the standard 721 implementation and 721A implementation? I've already played around with converting 721A to a Diamond structure and used it. With a little more work I could get it into the format that solidstate likes the code to be in. If this is something you'd be interested in having in the repo as just another option for people to use I'd be happy to do it myself.
The text was updated successfully, but these errors were encountered: