Skip to content

Commit 9e2fce2

Browse files
authored
fix: remove unneeded icons from themes (#2748)
1 parent 388eb97 commit 9e2fce2

7 files changed

Lines changed: 12 additions & 170 deletions

File tree

.changeset/nice-bobcats-exist.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@solid-design-system/tokens': patch
3+
---
4+
5+
Removed unneeded \_internal icons to reduce bundle size and confusion

.changeset/proud-eagles-follow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@solid-design-system/docs': patch
3+
---
4+
5+
Emphasized non-usage of \_internal icons

packages/docs/src/stories/components/icon.stories.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ export const Size = {
120120
* You can register additional icons to use with the `<sd-icon>` component through icon libraries. Icon files can exist locally or on a CORS-enabled endpoint (e.g. a CDN). There is no limit to how many icon libraries you can register and there is no cost associated with registering them, as individual icons are only requested when they're used.
121121
* Solid ships with three built-in icon libraries, `default`, `_internal`, and `sd-status-assets`:
122122
* - `default`: The `default` icon library refers to the official CDN by Union Investment which is fed by Celum. It is provided by the brand department, therefore requests towards the icons itself need to be addressed accordingly.
123-
* - `_internal`: These icons are an integrated library of the Solid Components to ensure they're always available. They are a subset of Union Investment's official icons. As names and visuals may change over time, internal icons should NOT be used directly.
124123
* - `sd-status-assets`: This library contains icons specifically for status indicators like the `sd-status-badge` component.
124+
* - `_internal`: These icons are an integrated library of the Solid Components to ensure they're always available. They are a subset of Union Investment's official icons and are themed for consistency. As names and visuals may change over time, internal icons should NOT be used directly!
125125
*
126126
* To register an additional icon library, use the `registerIconLibrary()` function that's exported from `utilities/icon-library.js`. At a minimum, you must provide a name and a resolver function. The resolver function translates an icon name to a URL where the corresponding SVG file exists. Refer to the examples below to better understand how it works.
127127
*

packages/tokens/themes/kid/icons.css

Lines changed: 0 additions & 50 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/tokens/themes/kid/kid.css

Lines changed: 0 additions & 50 deletions
Large diffs are not rendered by default.

packages/tokens/themes/vb/icons.css

Lines changed: 1 addition & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/tokens/themes/vb/vb.css

Lines changed: 0 additions & 34 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)