Simplify BankForks::banks()

ryoqun · ryoqun · commit fa17bb68c7ef · 2023-10-21T13:34:06.000+09:00
diff --git a/runtime/src/bank_forks.rs b/runtime/src/bank_forks.rs
@@ -83,11 +83,8 @@ impl BankForks {
         Self::new_from_banks(&[Arc::new(bank)], root)
     }
 
-    pub fn banks(&self) -> HashMap<Slot, Arc<Bank>> {
-        self.banks
-            .iter()
-            .map(|(&k, b)| (k, b.clone_without_scheduler()))
-            .collect()
+    pub fn banks(&self) -> &HashMap<Slot, BankWithScheduler> {
+        &self.banks
     }
 
     pub fn get_vote_only_mode_signal(&self) -> Arc<AtomicBool> {

Original file line number	Diff line number	Diff line change
`@@ -83,11 +83,8 @@ impl BankForks {`
`83`	`83`	`Self::new_from_banks(&[Arc::new(bank)], root)`
`84`	`84`	`}`
`85`	`85`
`86`		`- pub fn banks(&self) -> HashMap<Slot, Arc<Bank>> {`
`87`		`- self.banks`
`88`		`- .iter()`
`89`		`- .map(\|(&k, b)\| (k, b.clone_without_scheduler()))`
`90`		`- .collect()`
	`86`	`+ pub fn banks(&self) -> &HashMap<Slot, BankWithScheduler> {`
	`87`	`+ &self.banks`
`91`	`88`	`}`
`92`	`89`
`93`	`90`	`pub fn get_vote_only_mode_signal(&self) -> Arc<AtomicBool> {`