feedback

Author: jstarry

core/src/heaviest_subtree_fork_choice.rs

@@ -863,7 +863,7 @@ impl HeaviestSubtreeForkChoice {
                     Some(false) => None,
                     None => {
                         if !tower.is_stray_last_vote() {
-                            // Unless last vote is stray and stale, self.bast_slot(last_voted_slot) must return
+                            // Unless last vote is stray and stale, self.is_candidate(last_voted_slot_hash) must return
                             // Some(_), justifying to panic! here.
                             // Also, adjust_lockouts_after_replay() correctly makes last_voted_slot None,
                             // if all saved votes are ancestors of replayed_root_slot. So this code shouldn't be

core/src/replay_stage.rs

@@ -5644,7 +5644,7 @@ pub(crate) mod tests {
         assert_eq!(vote_fork.unwrap(), 4);
         assert_eq!(reset_fork.unwrap(), 4);
 
-        // Record the vote for 5
+        // Record the vote for 5 which is not on the heaviest fork.
         tower.record_bank_vote(
             &bank_forks.read().unwrap().get(5).unwrap(),
             &Pubkey::default(),