fix clippy

Author: behzadnouri

ledger/src/shred/legacy.rs

@@ -183,7 +183,7 @@ impl ShredDataTrait for ShredData {
         }
         self.payload
             .get(SHRED_DATA_OFFSET..size)
-            .ok_or_else(|| Error::InvalidPayloadSize(self.payload.len()))
+            .ok_or(Error::InvalidPayloadSize(self.payload.len()))
     }
 
     // Only for tests.

ledger/src/shred/merkle.rs

@@ -75,7 +75,7 @@ impl ShredData {
                     + SIZE_OF_MERKLE_ROOT
                     + usize::from(proof_size) * SIZE_OF_MERKLE_PROOF_ENTRY,
             )
-            .ok_or_else(|| Error::InvalidProofSize(proof_size))
+            .ok_or(Error::InvalidProofSize(proof_size))
     }
 }
 
@@ -97,7 +97,7 @@ impl ShredCode {
                     + SIZE_OF_MERKLE_ROOT
                     + SIZE_OF_MERKLE_PROOF_ENTRY * usize::from(proof_size),
             )
-            .ok_or_else(|| Error::InvalidProofSize(proof_size))
+            .ok_or(Error::InvalidProofSize(proof_size))
     }
 }
 
@@ -274,7 +274,7 @@ impl ShredDataTrait for ShredData {
         }
         self.payload
             .get(SHRED_DATA_OFFSET..size)
-            .ok_or_else(|| Error::InvalidPayloadSize(self.payload.len()))
+            .ok_or(Error::InvalidPayloadSize(self.payload.len()))
     }
 
     // Only for tests.

ledger/src/shred/shred_data.rs

@@ -84,9 +84,7 @@ impl ShredData {
     // Possibly zero pads bytes stored in blockstore.
     pub(crate) fn resize_stored_shred(shred: Vec<u8>) -> Result<Vec<u8>, Error> {
         match Shred::shred_variant_from_payload(&shred)? {
-            ShredVariant::LegacyCode | ShredVariant::MerkleCode(_) => {
-                return Err(Error::InvalidShredType);
-            }
+            ShredVariant::LegacyCode | ShredVariant::MerkleCode(_) => Err(Error::InvalidShredType),
             ShredVariant::MerkleData(_) => {
                 if shred.len() != merkle::ShredData::SIZE_OF_PAYLOAD {
                     return Err(Error::InvalidPayloadSize(shred.len()));