Revert "Error logging"

This reverts commit 18953c3.

Author: carllin

core/src/repair/cluster_slot_state_verifier.rs

@@ -853,7 +853,7 @@ pub(crate) fn check_slot_agrees_with_cluster(
     purge_repair_slot_counter: &mut PurgeRepairSlotCounter,
     slot_state_update: SlotStateUpdate,
 ) {
-    error!(
+    info!(
         "check_slot_agrees_with_cluster() slot: {}, root: {}, slot_state_update: {:?}",
         slot, root, slot_state_update
     );
@@ -870,7 +870,7 @@ pub(crate) fn check_slot_agrees_with_cluster(
             return;
         }
 
-        datapoint_error!(
+        datapoint_info!(
             "duplicate_slot",
             ("slot", slot, i64),
             (
@@ -902,7 +902,7 @@ pub(crate) fn check_slot_agrees_with_cluster(
             }
         }
 
-        datapoint_error!(
+        datapoint_info!(
             "duplicate_confirmed_slot",
             ("slot", slot, i64),
             (

core/src/replay_stage.rs

@@ -613,7 +613,6 @@ impl ReplayStage {
                 let mut ancestors = bank_forks.read().unwrap().ancestors();
                 let mut descendants = bank_forks.read().unwrap().descendants();
                 let did_complete_bank = Self::replay_active_banks(
-                    &my_pubkey,
                     &blockstore,
                     &bank_forks,
                     &my_pubkey,
@@ -921,9 +920,8 @@ impl ReplayStage {
                 // Reset onto a fork
                 if let Some(reset_bank) = reset_bank {
                     if last_reset != reset_bank.last_blockhash() {
-                        error!(
-                            "{} vote bank: {:?} reset bank: {:?}",
-                            my_pubkey,
+                        info!(
+                            "vote bank: {:?} reset bank: {:?}",
                             vote_bank
                                 .as_ref()
                                 .map(|(b, switch_fork_decision)| (b.slot(), switch_fork_decision)),
@@ -2701,7 +2699,6 @@ impl ReplayStage {
 
     #[allow(clippy::too_many_arguments)]
     fn process_replay_results(
-        id: &Pubkey,
         blockstore: &Blockstore,
         bank_forks: &RwLock<BankForks>,
         progress: &mut ProgressMap,
@@ -2786,7 +2783,6 @@ impl ReplayStage {
                     transaction_status_sender.send_transaction_status_freeze_message(bank);
                 }
                 bank.freeze();
-                error!("{} froze bank {} {:?}", id, bank_slot, bank.hash());
                 datapoint_info!(
                     "bank_frozen",
                     ("slot", bank_slot, i64),
@@ -2891,7 +2887,6 @@ impl ReplayStage {
 
     #[allow(clippy::too_many_arguments)]
     fn replay_active_banks(
-        id: &Pubkey,
         blockstore: &Blockstore,
         bank_forks: &RwLock<BankForks>,
         my_pubkey: &Pubkey,
@@ -2970,7 +2965,6 @@ impl ReplayStage {
             };
 
             Self::process_replay_results(
-                id,
                 blockstore,
                 bank_forks,
                 progress,

local-cluster/tests/local_cluster.rs

@@ -5316,10 +5316,7 @@ fn test_duplicate_shreds_switch_failure() {
         if original_frozen_hash != dup_frozen_hash {
             break;
         } else {
-            panic!(
-                "Duplicate leader and partition target got same hash: {}",
-                original_frozen_hash
-            );
+            panic!("Duplicate leader and partition target got same hash: {}", original_frozen_hash);
         }
     }