Allow events to be tracked on the onSessionUpdate callback (close #1213)

* Allow events to be tracked on the onSessionUpdate callback (close #1213)
* Increased the bundlemon browser-tracker-core size at a reasonable value
* Add onSessionUpdate integration test
#1214

Author: igneel64

.bundlemonrc.json

@@ -22,7 +22,7 @@
     },
     {
       "path": "./libraries/browser-tracker-core/dist/index.module.js",
-      "maxSize": "25kb",
+      "maxSize": "26kb",
       "maxPercentIncrease": 10
     },
     {

common/changes/@snowplow/browser-tracker-core/issue-1213-allow-events-on-session-update-callback_2023-06-27-07-36.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@snowplow/browser-tracker-core",
+      "comment": "Allow events to be tracked on the onSessionUpdate callback",
+      "type": "none"
+    }
+  ],
+  "packageName": "@snowplow/browser-tracker-core"
+}

common/changes/@snowplow/javascript-tracker/issue-1213-allow-events-on-session-update-callback_2023-06-28-15-24.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@snowplow/javascript-tracker",
+      "comment": "Added onSessionUpdate callback integration test",
+      "type": "none"
+    }
+  ],
+  "packageName": "@snowplow/javascript-tracker"
+}

common/config/rush/pnpm-lock.yaml

@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "1a9deb48a8d2843fb67d9c93ff618d8373ca31c8",
+  "pnpmShrinkwrapHash": "b3670fdd35939880fb5506b045e5826aeab84996",
   "preferredVersionsHash": "bf21a9e8fbc5a3846fb05b4fa0859e0917b2202f"
 }

common/config/rush/repo-state.json

@@ -171,10 +171,7 @@ export function initializeDomainUserId(idCookie: ParsedIdCookie, configAnonymous
 }
 
 type NewSessionOptions = {
-  memorizedVisitCount?: number;
-  onSessionUpdateCallback?: (sessionState: ClientSession) => void;
-  configStateStorageStrategy: string;
-  configAnonymousTracking: boolean;
+  memorizedVisitCount: number;
 };
 
 /**
@@ -189,11 +186,11 @@ type NewSessionOptions = {
  * @param options.onSessionUpdateCallback Session callback triggered on every session update
  * @returns New session ID
  */
-export function startNewIdCookieSession(idCookie: ParsedIdCookie, options: NewSessionOptions) {
-  const { memorizedVisitCount, configStateStorageStrategy, configAnonymousTracking, onSessionUpdateCallback } = {
-    memorizedVisitCount: 1,
-    ...options,
-  };
+export function startNewIdCookieSession(
+  idCookie: ParsedIdCookie,
+  options: NewSessionOptions = { memorizedVisitCount: 1 }
+) {
+  const { memorizedVisitCount } = options;
 
   // If cookies are enabled, base visit count and session ID on the cookies
   if (cookiesEnabledInIdCookie(idCookie)) {
@@ -216,10 +213,6 @@ export function startNewIdCookieSession(idCookie: ParsedIdCookie, options: NewSe
   idCookie[firstEventIdIndex] = '';
   idCookie[firstEventTsInMsIndex] = undefined;
 
-  if (onSessionUpdateCallback) {
-    onSessionUpdateCallback(clientSessionFromIdCookie(idCookie, configStateStorageStrategy, configAnonymousTracking));
-  }
-
   return sessionId;
 }