Skip to content

Commit 1b2268a

Browse files
committed
Fixed bug where non-String values are not being added to our payload (#71)
1 parent 64e74b5 commit 1b2268a

File tree

6 files changed

+9
-5
lines changed

6 files changed

+9
-5
lines changed

CHANGELOG

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
Version 0.13.1 (2014-01-28)
2+
---------------------------
3+
Fixed bug where non-String values are not being added to our payload (#71)
4+
15
Version 0.13.0 (2014-01-26)
26
---------------------------
37
Added fully retrospective CHANGELOG (#20)

examples/web/async.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
(function() {
4646
var sp = document.createElement('script'); sp.type = 'text/javascript'; sp.async = true; sp.defer = true;
47-
sp.src = ('https:' == document.location.protocol ? 'https' : 'http') + '://d1fc8wv8zag5ca.cloudfront.net/0.13.0/sp.js';
47+
sp.src = ('https:' == document.location.protocol ? 'https' : 'http') + '://d1fc8wv8zag5ca.cloudfront.net/0.13.1/sp.js';
4848
// sp.src = '../../dist/snowplow.js'; // For testing
4949
var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(sp, s);
5050
})();

examples/web/sync.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
<!-- Snowplow starts plowing -->
2121
<script type="text/javascript">
22-
var spSrc = ('https:' == document.location.protocol ? 'https' : 'http') + '://d1fc8wv8zag5ca.cloudfront.net/0.13.0/sp.js';
22+
var spSrc = ('https:' == document.location.protocol ? 'https' : 'http') + '://d1fc8wv8zag5ca.cloudfront.net/0.13.1/sp.js';
2323
// var spSrc = '../../dist/snowplow.js'; // For testing
2424
document.write(unescape("%3Cscript src='" + spSrc + "' type='text/javascript'%3E%3C/script%3E"));
2525
</script>

src/js/banner.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Snowplow - The world's most powerful web analytics platform
33
*
44
* @description JavaScript tracker for Snowplow
5-
* @version 0.13.0
5+
* @version 0.13.1
66
* @author Alex Dean, Simon Andersson, Anthon Pang
77
* @copyright Anthon Pang, Snowplow Analytics Ltd
88
* @license Simplified BSD

src/js/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ var SnowPlow = SnowPlow || function() {
4444
return {
4545

4646
/* Tracker identifier with version */
47-
version: 'js-0.13.0', // Update banner.js too
47+
version: 'js-0.13.1', // Update banner.js too
4848

4949
expireDateTime: null,
5050

src/js/tracker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ SnowPlow.Tracker = function Tracker(argmap) {
658658
var str = '';
659659

660660
var addNvPair = function (key, value, encode) {
661-
if (SnowPlow.isNonEmptyString(value)) {
661+
if (value !== undefined && value !== null && value !== '') {
662662
var sep = (str.length > 0) ? "&" : "?";
663663
str += sep + key + '=' + (encode ? SnowPlow.encodeWrapper(value) : value);
664664
}

0 commit comments

Comments
 (0)