Update wif_util.py create_attestation #2315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting if elif .. statement into visible map
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Comment on lines
-308
to
+319
| attestation: WorkloadIdentityAttestation = None | ||
| if provider == AttestationProvider.AWS: | ||
| attestation = create_aws_attestation() | ||
| elif provider == AttestationProvider.AZURE: | ||
| attestation = create_azure_attestation(entra_resource) | ||
| elif provider == AttestationProvider.GCP: | ||
| attestation = create_gcp_attestation() | ||
| elif provider == AttestationProvider.OIDC: | ||
| attestation = create_oidc_attestation(token) | ||
| elif provider is None: | ||
| attestation = create_autodetect_attestation(entra_resource, token) | ||
| provider_map = ( | ||
| lambda: None, | ||
| { | ||
| AttestationProvider.AWS: lambda: create_aws_attestation(), | ||
| AttestationProvider.AZURE: lambda: create_azure_attestation(entra_resource), | ||
| AttestationProvider.GCP: lambda: create_gcp_attestation(), | ||
| AttestationProvider.OIDC: lambda: create_oidc_attestation(token), | ||
| None: lambda: create_autodetect_attestation(entra_resource, token) | ||
| } | ||
| ) | ||
| attestation: WorkloadIdentityAttestation = provider_map(provider) |
There was a problem hiding this comment.
I don't necessarily think this is more readable. A simple set of if-else conditions is very easy to understand by anyone who knows basic Python. OTOH, I'm not sure why we'd create a tuple of an empty callable and a dictionary, then use the tuple as a dictionary later.
Also, note that the order that we check the providers is intentional (based on perceived usage share). This is much easier to see in the basic procedural code rather than the indirection through a dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting if elif .. statement into visible map
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Code enhances readability and easier to maintain
Please describe how your code solves the related issue.
Just converting long if elif statement into readable map