Skip to content

Commit cc7f2b7

Browse files
fix last test failure
1 parent 480f064 commit cc7f2b7

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/snowflake/connector/config_manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ def read_config(
330330
continue
331331

332332
if (
333-
sliceoptions.check_permissions # Skip checking if this file couldn't hold sensitive information
333+
sliceoptions.check_permissions # Skip checking if this slice isn't holding sensitive information
334334
# Same check as openssh does for permissions
335335
# https://github.com/openssh/openssh-portable/blob/2709809fd616a0991dc18e3a58dea10fb383c3f0/readconf.c#LL2264C1-L2264C1
336336
and filep.stat().st_mode & READABLE_BY_OTHERS != 0

test/integ/test_connection.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
import snowflake.connector
2424
from snowflake.connector import DatabaseError, OperationalError, ProgrammingError
25+
from snowflake.connector.compat import IS_WINDOWS
2526
from snowflake.connector.connection import (
2627
DEFAULT_CLIENT_PREFETCH_THREADS,
2728
SnowflakeConnection,
@@ -747,7 +748,8 @@ def test_invalid_connection_parameters_turned_off(conn_cnx):
747748
) as conn:
748749
assert conn._autocommit == "True"
749750
assert conn._applucation == "this is a typo or my own variable"
750-
assert len(w) == 0
751+
# TODO: Windows tests will emit a warning about connections file privileges
752+
assert len(w) == (1 if IS_WINDOWS else 0)
751753

752754

753755
def test_invalid_connection_parameters_only_warns(conn_cnx):

0 commit comments

Comments
 (0)