Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1889398: Handle endpoint without protocol for GCS #994

Merged

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

SNOW-1889398

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner January 20, 2025 08:16
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (e8cb18c) to head (3b0c43d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   88.97%   88.94%   -0.03%     
==========================================
  Files          72       72              
  Lines        6985     6985              
==========================================
- Hits         6215     6213       -2     
- Misses        770      772       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 67d0c25 into master Jan 20, 2025
46 of 47 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1889398-handle-endpoint-without-protocol-for-gcs branch January 20, 2025 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants