Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1346341 adding destination to httpsAgent cache key to be able to apply separate settings for separate destinations #946

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Nov 5, 2024

Description

Please explain the changes you made here.

  • Added the destination when the driver creates the agentID for httpsAgent cache.
  • Added the testing for HTTP agent cache.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (3bf15bc) to head (5b46702).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.01%     
==========================================
  Files          69       69              
  Lines        6667     6677      +10     
==========================================
+ Hits         5926     5936      +10     
  Misses        741      741              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1781419 SNOW-1781419 (from 947) when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar Nov 5, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review November 6, 2024 00:20
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner November 6, 2024 00:20
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SNOW-1781419 (from 947) when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar SNOW-1346341 adding destination to agent cache key to be able to apply separate settings for separate destinations Nov 6, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SNOW-1346341 adding destination to agent cache key to be able to apply separate settings for separate destinations SNOW-1346341 adding destination to httpsAgent cache key to be able to apply separate settings for separate destinations Nov 6, 2024
lib/http/node.js Outdated Show resolved Hide resolved
lib/http/node.js Show resolved Hide resolved
lib/http/node.js Outdated Show resolved Hide resolved
lib/http/node.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 081d28b into master Nov 7, 2024
59 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1781419 branch November 7, 2024 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants