-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1346341 adding destination to httpsAgent cache key to be able to apply separate settings for separate destinations #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
==========================================
+ Coverage 88.88% 88.90% +0.01%
==========================================
Files 69 69
Lines 6667 6677 +10
==========================================
+ Hits 5926 5936 +10
Misses 741 741 ☔ View full report in Codecov by Sentry. |
sfc-gh-ext-simba-jy
changed the title
SNOW-1781419
SNOW-1781419 (from 947) when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar
Nov 5, 2024
sfc-gh-ext-simba-jy
requested review from
sfc-gh-pmotacki and
sfc-gh-fpawlowski
November 5, 2024 20:57
sfc-gh-dszmolka
changed the title
SNOW-1781419 (from 947) when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar
SNOW-1346341 adding destination to agent cache key to be able to apply separate settings for separate destinations
Nov 6, 2024
sfc-gh-dszmolka
changed the title
SNOW-1346341 adding destination to agent cache key to be able to apply separate settings for separate destinations
SNOW-1346341 adding destination to httpsAgent cache key to be able to apply separate settings for separate destinations
Nov 6, 2024
sfc-gh-ext-simba-jy
requested review from
sfc-gh-fpawlowski,
sfc-gh-dszmolka and
sfc-gh-dprzybysz
November 6, 2024 17:56
sfc-gh-pmotacki
approved these changes
Nov 7, 2024
sfc-gh-fpawlowski
approved these changes
Nov 7, 2024
sfc-gh-dprzybysz
approved these changes
Nov 7, 2024
sfc-gh-pmotacki
force-pushed
the
SNOW-1781419
branch
from
November 7, 2024 11:46
41d97d0
to
5b46702
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)