Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-985414 Do not swallow error for file uploading #991

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 6, 2023

Description

SNOW-985414 Go does not throw exceptions, instead errors are returned. Here, the error was not propagated to the caller.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 6, 2023 10:06
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-985414-upload-file-error branch from 2f951f5 to 7ec8b10 Compare December 6, 2023 10:10
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-985414-upload-file-error branch from 7ec8b10 to 756da19 Compare December 6, 2023 10:12
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b8e6736) 82.80% compared to head (756da19) 82.79%.
Report is 2 commits behind head on master.

Files Patch % Lines
bind_uploader.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   82.80%   82.79%   -0.02%     
==========================================
  Files          50       50              
  Lines        9684     9687       +3     
==========================================
+ Hits         8019     8020       +1     
- Misses       1665     1667       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus merged commit e799467 into master Dec 6, 2023
21 of 23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-985414-upload-file-error branch December 6, 2023 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants