Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1825790 Token cache refactor - v2 #1299

Merged
merged 2 commits into from
Feb 5, 2025
Merged

SNOW-1825790 Token cache refactor - v2 #1299

merged 2 commits into from
Feb 5, 2025

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Feb 4, 2025 •
edited
Loading

Description

SNOW-XXX Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from b5484da to 0f653cf Compare February 4, 2025 12:19
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from 0f653cf to 3a3de37 Compare February 4, 2025 13:33
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review February 4, 2025 13:33
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner February 4, 2025 13:33
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 88.60759% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (e926883) to head (3a3de37).

Files with missing lines Patch % Lines
secure_storage_manager.go 87.67% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   82.20%   82.17%   -0.04%     
==========================================
  Files          55       55              
  Lines       13636    13646      +10     
==========================================
+ Hits        11209    11213       +4     
- Misses       2427     2433       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-dheyman
sfc-gh-dheyman approved these changes Feb 4, 2025
View reviewed changes
secure_storage_manager.go Show resolved Hide resolved
secure_storage_manager.go Outdated Show resolved Hide resolved
secure_storage_manager.go Show resolved Hide resolved
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski approved these changes Feb 5, 2025
View reviewed changes
Copy link

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much abstraction IMHO, but looks good to me

secure_storage_manager.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) February 5, 2025 09:41
@sfc-gh-pfus sfc-gh-pfus merged commit d8df82e into master Feb 5, 2025
34 of 37 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1825790-token-cache branch February 5, 2025 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski sfc-gh-jszczerbinski approved these changes

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-dheyman @sfc-gh-jszczerbinski