From 67139c18195a3fc3b15121fd3de6eff8f397ed42 Mon Sep 17 00:00:00 2001 From: John Yun Date: Thu, 19 Dec 2024 11:22:13 -0800 Subject: [PATCH] fix --- gcs_storage_client.go | 3 ++- gcs_storage_client_test.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gcs_storage_client.go b/gcs_storage_client.go index 6ad9be46e..8558094ba 100644 --- a/gcs_storage_client.go +++ b/gcs_storage_client.go @@ -411,8 +411,9 @@ func newGcsClient() gcsAPI { } func getGcsCustomEndpoint(info *execResponseStageInfo) string { - // TODO: SNOW-1789759 hardcoded region will be replaced in the future endpoint := "https://storage.googleapis.com" + + // TODO: SNOW-1789759 hardcoded region will be replaced in the future isRegionalURLEnabled := (strings.ToLower(info.Region) == gcsRegionMeCentral2) || info.UseRegionalURL if info.EndPoint != "" { endpoint = fmt.Sprintf("https://%s", info.EndPoint) diff --git a/gcs_storage_client_test.go b/gcs_storage_client_test.go index 3f039fb91..88c24176e 100644 --- a/gcs_storage_client_test.go +++ b/gcs_storage_client_test.go @@ -1136,7 +1136,7 @@ func TestGetGcsCustomEndpoint(t *testing.T) { out string }{ { - desc: "when both the endPoint is not specified and UseRegionalURL is false", + desc: "when the endPoint is not specified and UseRegionalURL is false", in: execResponseStageInfo{ UseRegionalURL: false, EndPoint: "",