Skip to content

Factor wire module out into its own crate? #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canndrew opened this issue Feb 13, 2018 · 6 comments
Closed

Factor wire module out into its own crate? #162

canndrew opened this issue Feb 13, 2018 · 6 comments

Comments

@canndrew
Copy link
Contributor

I've written a crate that depends on smoltcp, but I'm only using the wire module. I just noticed that smoltcp requires nightly but I really want to be able to run on stable. The wire module alone doesn't require nightly.

Would you be interested in factoring wire out into a separate crate, called smoltcp-wire or something? I'm probably going to do this anyway. It's really just a matter of who wants to take ownership/responsibility for it and whether we want to de-duplicate code.

@dlrobertson
Copy link
Collaborator

This is duplicate of #54. It may be best close this and post there. Just so everything is in one place.

Either way, thanks for bringing this up! It is actually something I've had a few conversations about recently.

@canndrew
Copy link
Contributor Author

Thanks! I'll close this then.

@whitequark
Copy link
Contributor

@canndrew Um, what?

First, I am absolutely against you hijacking the smoltcp namespace on crates.io. Why did you even think this is okay?

Second, the fact that smoltcp depends on nightly Rust is transient. The only nightly feature used is the slice::rotate_left function. You're free to wait until that's stabilized (rust-lang/rust#41891), or just inline it into the file where it's used.

@canndrew
Copy link
Contributor Author

canndrew commented Feb 15, 2018

First, I am absolutely against you hijacking the smoltcp namespace on crates.io. Why did you even think this is okay?

I didn't. It's a matter of whether you want to create/own the crate or whether I should fork it. If I was to fork it I'd rename it too. I'm sorry if that wasn't clear.

Second, the fact that smoltcp depends on nightly Rust is transient.

Okay, cool. How long do you think until it's stabilised? (Edit: nevermind, looks like it will happen fairly soon.)

@whitequark
Copy link
Contributor

I have no objections to inlining the function if you want a release of smoltcp that works on stable, like, right now.

@whitequark
Copy link
Contributor

@canndrew smoltcp will work on stable again at 1.26: rust-lang/rust#41891 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants