-
Notifications
You must be signed in to change notification settings - Fork 457
Factor wire module out into its own crate? #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is duplicate of #54. It may be best close this and post there. Just so everything is in one place. Either way, thanks for bringing this up! It is actually something I've had a few conversations about recently. |
Thanks! I'll close this then. |
@canndrew Um, what? First, I am absolutely against you hijacking the Second, the fact that |
I didn't. It's a matter of whether you want to create/own the crate or whether I should fork it. If I was to fork it I'd rename it too. I'm sorry if that wasn't clear.
Okay, cool. How long do you think until it's stabilised? (Edit: nevermind, looks like it will happen fairly soon.) |
I have no objections to inlining the function if you want a release of smoltcp that works on stable, like, right now. |
@canndrew smoltcp will work on stable again at 1.26: rust-lang/rust#41891 (comment). |
I've written a crate that depends on
smoltcp
, but I'm only using thewire
module. I just noticed thatsmoltcp
requires nightly but I really want to be able to run on stable. Thewire
module alone doesn't require nightly.Would you be interested in factoring
wire
out into a separate crate, calledsmoltcp-wire
or something? I'm probably going to do this anyway. It's really just a matter of who wants to take ownership/responsibility for it and whether we want to de-duplicate code.The text was updated successfully, but these errors were encountered: