Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"target: popup" (etc) demos don't work in current Chromium #164

Open
jmandel opened this issue Mar 17, 2023 · 2 comments
Open

"target: popup" (etc) demos don't work in current Chromium #164

jmandel opened this issue Mar 17, 2023 · 2 comments

Comments

@jmandel
Copy link
Member

jmandel commented Mar 17, 2023

  1. Visit https://fmv99.csb.app/
  2. Click "Authorize in a popup window"

What's expected: a new window or tab opens onto the authz endpoint
What happens: the main window redirects to the authz endpoint

This appears to happen when window.open is called in a context where no user event has occurred. One straightforward fix is to add an <button>Begin Authorization</button> and trigger smart.authorize as a result of clicking that button.

@vlad-ignatov
Copy link
Collaborator

Seems to work fine for me in Chrome/Mac.

@jmandel
Copy link
Member Author

jmandel commented Mar 17, 2023

Chromium 109 on Linux. I'm not prompted to enable pop-ups. Or if I am, the UX is too challenging.

For a demonstration, I think having a no nonsense button that works consistently would be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants