Skip to content

Recording rules duplicates check #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r3code opened this issue Apr 4, 2023 · 2 comments
Open

Recording rules duplicates check #493

r3code opened this issue Apr 4, 2023 · 2 comments

Comments

@r3code
Copy link
Contributor

r3code commented Apr 4, 2023

I've noticed that if I pass a folder to sloth validate it allows SLO duplicates to exist.

When creating a new SLO sometemes I copy spec from existing specs and forgot to change names.
Sloth perfectly validates and generates rules in such cases. But it can lead to duplicates of recording rules, and unpredictable behaviour durind recording.

We can deploy rules as prom, k8s, and openslo. Prom and K8S are almost the same and have equal slo_id format <service>-<slo.name>, but OpenSLO uses slightly different <service>-<slo.name>-<seq_no>.

So it looks like better not to mix spec types for the same service.
But if I have a folder with specs of one type, e.g. Prom specs for CLI generation, I want to know about slo duplicates in a folder or multifile yml.

r3code added a commit to r3code/sloth that referenced this issue Apr 4, 2023
r3code added a commit to r3code/sloth that referenced this issue Apr 4, 2023
r3code added a commit to r3code/sloth that referenced this issue Apr 5, 2023
r3code added a commit to r3code/sloth that referenced this issue Apr 5, 2023
r3code added a commit to vseinstrumentiru/sloth that referenced this issue Apr 5, 2023
r3code added a commit to r3code/sloth that referenced this issue Apr 10, 2023
r3code added a commit to r3code/sloth that referenced this issue Dec 11, 2024
Issue slok#493

Signed-off-by: Синявский Дмитрий Сергеевич <[email protected]>
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the stale label Mar 29, 2025
Copy link

This issue was closed because it has been stale for 15 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2025
@slok slok reopened this Apr 14, 2025
@slok slok removed the stale label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants