Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.9.x: C++ SDK download links are broken #7242

Closed
scomx opened this issue Dec 31, 2024 · 4 comments · Fixed by #7248
Closed

Release v1.9.x: C++ SDK download links are broken #7242

scomx opened this issue Dec 31, 2024 · 4 comments · Fixed by #7248
Labels
a:ci Automation for CI (Continous integration system) and tests (mT,bO) bug Something isn't working
Milestone
1.9.2

Comments

@scomx
Copy link

scomx commented Dec 31, 2024

Bug Description

As per title, unable to download any release v1.9.x for Windows and/or Linux.

Viewer and LSP links are working.

Reproducible Code (if applicable)

No response

Environment Details

Slint version: 1.9.x
OS: Windows, Linux
Programming language: C++

Product Impact

No response
@scomx scomx added bug Something isn't working need triaging Issue that the owner of the area still need to triage labels Dec 31, 2024
@tronical
Copy link
Member

OOps.

Broken: https://github.com/slint-ui/slint/releases/download/v1.9.1/Slint-cpp-v1.9.1-Linux-x86_64.tar.gz
Correct: https://github.com/slint-ui/slint/releases/download/v1.9.1/Slint-cpp-1.9.1-Linux-x86_64.tar.gz

There's a v that snuck in.

@tronical
Copy link
Member

I fixed up the 1.9.1 release by hand, but keeping this open to investigate how to fix this in nightly_snapshot.yaml.

@tronical tronical added a:ci Automation for CI (Continous integration system) and tests (mT,bO) and removed need triaging Issue that the owner of the area still need to triage labels Dec 31, 2024
@tronical tronical added this to the 1.9.2 milestone Dec 31, 2024
@tronical
Copy link
Member

This is the faulty run: https://github.com/slint-ui/slint/actions/runs/12446538360/job/34749740822

@scomx
Copy link
Author

scomx commented Dec 31, 2024

Thanks, considerable improvement :)

tronical added a commit that referenced this issue Jan 2, 2025
@tronical
Fix for download links for C++ binary packages in release notes
212322d 
The {download_version} variable is either "nightly" or "vX.Y.Z", but the C++ binary packages dont have the "v" prefix. So use the plain version variable for the file name infix in the link.

Fixes #7242
@tronical tronical mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:ci Automation for CI (Continous integration system) and tests (mT,bO) bug Something isn't working
Projects
None yet
Milestone
1.9.2
Development

Successfully merging a pull request may close this issue.

Fix for download links for C++ binary packages in release notes slint-ui/slint
2 participants
@tronical @scomx