compiler: some clippy fixes

Author: dfaure-kdab

internal/compiler/llr/lower_expression.rs

@@ -972,7 +972,7 @@ fn grid_layout_cell_constraints(
 
     if repeater_count == 0 {
         let cells = llr_Expression::Array {
-            element_ty: element_ty.into(),
+            element_ty: element_ty,
             values: layout
                 .elems
                 .iter()
@@ -1027,7 +1027,7 @@ fn grid_layout_input_data(
 ) -> GridLayoutInputDataResult {
     let propref = |named_ref: &RowColExpr| match named_ref {
         RowColExpr::Literal(n) => llr_Expression::NumberLiteral((*n).into()),
-        RowColExpr::Named(nr) => llr_Expression::PropertyReference(ctx.map_property_reference(&nr)),
+        RowColExpr::Named(nr) => llr_Expression::PropertyReference(ctx.map_property_reference(nr)),
         RowColExpr::Auto => llr_Expression::NumberLiteral(i_slint_common::ROW_COL_AUTO as _),
     };
     let input_data_for_cell = |elem: &crate::layout::GridLayoutElement,

internal/compiler/object_tree.rs

@@ -551,10 +551,7 @@ impl Component {
 
     /// This is an interface introduced with the "interface" keyword
     pub fn is_interface(&self) -> bool {
-        match &self.root_element.borrow().base_type {
-            ElementType::Interface => true,
-            _ => false,
-        }
+        matches!(&self.root_element.borrow().base_type, ElementType::Interface)
     }
 
     /// Returns the names of aliases to global singletons, exactly as
@@ -1087,11 +1084,11 @@ fn expected_relationship_to_parent(node: &syntax_nodes::Element) -> Option<Paren
     let implements_inherits_identifier =
         parent.children_with_tokens().filter(|n| n.kind() == SyntaxKind::Identifier).nth(1)?;
     let token = implements_inherits_identifier.as_token()?;
-    return match token.text() {
+    match token.text() {
         "inherits" => Some(ParentRelationship::Inherits),
         "implements" => Some(ParentRelationship::Implements),
         _ => None,
-    };
+    }
 }
 
 impl Element {
@@ -1129,7 +1126,7 @@ impl Element {
                 (Ok(ElementType::Component(c)), Some(ParentRelationship::Implements)) => {
                     if !diag.enable_experimental {
                         diag.push_error(
-                            format!("'implements' is an experimental feature"),
+                            "'implements' is an experimental feature".into(),
                             &base_node,
                         );
                         ElementType::Error
@@ -1149,7 +1146,7 @@ impl Element {
                 (Ok(ElementType::Builtin(_bt)), Some(ParentRelationship::Implements)) => {
                     if !diag.enable_experimental {
                         diag.push_error(
-                            format!("'implements' is an experimental feature"),
+                            "'implements' is an experimental feature".into(),
                             &base_node,
                         );
                     } else {

internal/compiler/parser/document.rs

@@ -141,12 +141,12 @@ pub fn parse_component(p: &mut impl Parser) -> bool {
     }
     if is_global {
         if p.peek().kind() == SyntaxKind::ColonEqual {
-            p.warning(format!("':=' to declare a global is deprecated. Remove the ':='"));
+            p.warning("':=' to declare a global is deprecated. Remove the ':='");
             p.consume();
         }
     } else if is_interface {
         if p.peek().kind() == SyntaxKind::ColonEqual {
-            p.error(format!("':=' to declare an interface is not supported. Remove the ':='"));
+            p.error("':=' to declare an interface is not supported. Remove the ':='");
             p.consume();
         }
     } else if !is_new_component {