UnusedPrivateElementsSniff - optimization for classes without methods and properties

kukulich · ondrejmirtes · commit 702b98967fd3 · 2016-04-29T14:27:19.000+02:00
diff --git a/SlevomatCodingStandard/Sniffs/Classes/UnusedPrivateElementsSniff.php b/SlevomatCodingStandard/Sniffs/Classes/UnusedPrivateElementsSniff.php
@@ -73,7 +73,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $classPointer)
 		$reportedProperties = $this->getProperties($phpcsFile, $tokens, $classToken);
 		$reportedMethods = $this->getMethods($phpcsFile, $tokens, $classToken);
 
-		if (count($reportedProperties) === 0) {
+		if (count($reportedProperties) + count($reportedMethods) === 0) {
 			return;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $classPointer)`
`73`	`73`	`$reportedProperties = $this->getProperties($phpcsFile, $tokens, $classToken);`
`74`	`74`	`$reportedMethods = $this->getMethods($phpcsFile, $tokens, $classToken);`
`75`	`75`
`76`		`- if (count($reportedProperties) === 0) {`
	`76`	`+ if (count($reportedProperties) + count($reportedMethods) === 0) {`
`77`	`77`	`return;`
`78`	`78`	`}`
`79`	`79`