Fix TypeError via JumpStatementsSpacingSniff when return is on the first line of the file

Author: herndlm

SlevomatCodingStandard/Sniffs/ControlStructures/AbstractControlStructureSpacing.php

@@ -217,7 +217,9 @@ protected function checkLinesBefore(File $phpcsFile, int $controlStructurePointe
 			$phpcsFile->fixer->replaceToken($pointerBefore, '<?php');
 		}
 
-		FixerHelper::removeBetweenIncluding($phpcsFile, $pointerBefore + 1, $endOfLineBeforePointer);
+		if ($endOfLineBeforePointer !== null) {
+			FixerHelper::removeBetweenIncluding($phpcsFile, $pointerBefore + 1, $endOfLineBeforePointer);
+		}
 
 		$linesToAdd = $hasCommentWithLineEndBefore ? $requiredLinesCountBefore - 1 : $requiredLinesCountBefore;
 		for ($i = 0; $i <= $linesToAdd; $i++) {

tests/Sniffs/ControlStructures/JumpStatementsSpacingSniffTest.php

@@ -292,6 +292,22 @@ public function testModifiedSettingsErrors(): void
 		self::assertAllFixedInFile($report);
 	}
 
+	public function testAtTheBeginnningOfFile(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/jumpStatementsSpacingAtTheBeginningOfFile.php');
+
+		self::assertSame(1, $report->getErrorCount());
+
+		self::assertSniffError(
+			$report,
+			1,
+			JumpStatementsSpacingSniff::CODE_INCORRECT_LINES_COUNT_BEFORE_CONTROL_STRUCTURE,
+			'Expected 1 line before "return", found -1.'
+		);
+
+		self::assertAllFixedInFile($report);
+	}
+
 	public function testAtTheEndOfFile(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/jumpStatementsSpacingAtTheEndOfFile.php');

tests/Sniffs/ControlStructures/data/jumpStatementsSpacingAtTheBeginningOfFile.fixed.php

@@ -0,0 +1,3 @@
+<?php
+
+return true;

tests/Sniffs/ControlStructures/data/jumpStatementsSpacingAtTheBeginningOfFile.php

@@ -0,0 +1 @@
+<?php return true;