Skip to content

Conversation

@ewanek1
Copy link

@ewanek1 ewanek1 commented Aug 16, 2025

Summary

This PR builds upon #486. It continues iterating on the GitHub composite action and workflow that runs Slack CLI commands directly in CI/CD.

Notes on Changes

Added action inputs for common flags including verbose and CLI version

Re-running a workflow automatically enables verbose output

Removed the flag-parsing script in favor of direct command execution via slack ${{ inputs.command }}

Added --skip-update flag to prevent auto-updates during installation

Enabled SLACK_DISABLE_TELEMETRY variable so usage won’t bump up numbers in collecting metrics

Updated logging to match GitHub's logger

Moved major logic into action.yml as a proper composite action

Requirements

@codecov
Copy link

codecov bot commented Aug 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (a560f02) to head (c7d8f2c).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/slack-cli-runner     #488   +/-   ##
=========================================================
  Coverage                     99.86%   99.86%           
=========================================================
  Files                             7        7           
  Lines                           722      722           
=========================================================
  Hits                            721      721           
  Misses                            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewanek1 This is an awesome set of changes! Things are looking good to me and I plan to share more thoughts soon but I'm excited for the feature branch and iteration to follow 👾 ✨

(steps.cache-cli.outputs.cache-hit != 'true')
shell: pwsh
run: |
irm https://downloads.slack-edge.com/slack-cli/install-windows-dev.ps1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 note: Changes of dev exist in this PR: slackapi/slack-cli#178

👁️‍🗨️ suggestion: I might've shared an incomplete command with this link too but perhaps this brings better luck? Let's keep note to test this at some point-

Suggested change
irm https://downloads.slack-edge.com/slack-cli/install-windows-dev.ps1
irm https://downloads.slack-edge.com/slack-cli/install-windows-dev.ps1 | iex

Copy link
Author

@ewanek1 ewanek1 Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily I think this let the CLI install properly! Although now it hangs on the very last step in the script. It echoes the command Run slack version --skip-update but doesn't go any further 🤔 Before this I got this error The term 'slack' is not recognized as a name of a cmdlet so I wonder if it has to do with the PATH variable. I'll keep trying to look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants