-
Notifications
You must be signed in to change notification settings - Fork 177
feat: add Slack CLI command runner workflow and installer composite action #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/slack-cli-runner
Are you sure you want to change the base?
feat: add Slack CLI command runner workflow and installer composite action #488
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/slack-cli-runner #488 +/- ##
=========================================================
Coverage 99.86% 99.86%
=========================================================
Files 7 7
Lines 722 722
=========================================================
Hits 721 721
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewanek1 This is an awesome set of changes! Things are looking good to me and I plan to share more thoughts soon but I'm excited for the feature branch and iteration to follow 👾 ✨
| (steps.cache-cli.outputs.cache-hit != 'true') | ||
| shell: pwsh | ||
| run: | | ||
| irm https://downloads.slack-edge.com/slack-cli/install-windows-dev.ps1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 note: Changes of dev exist in this PR: slackapi/slack-cli#178
👁️🗨️ suggestion: I might've shared an incomplete command with this link too but perhaps this brings better luck? Let's keep note to test this at some point-
| irm https://downloads.slack-edge.com/slack-cli/install-windows-dev.ps1 | |
| irm https://downloads.slack-edge.com/slack-cli/install-windows-dev.ps1 | iex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily I think this let the CLI install properly! Although now it hangs on the very last step in the script. It echoes the command Run slack version --skip-update but doesn't go any further 🤔 Before this I got this error The term 'slack' is not recognized as a name of a cmdlet so I wonder if it has to do with the PATH variable. I'll keep trying to look into this!
Summary
This PR builds upon #486. It continues iterating on the GitHub composite action and workflow that runs Slack CLI commands directly in CI/CD.
Notes on Changes
Added action inputs for common flags including
verboseandCLI versionRe-running a workflow automatically enables verbose output
Removed the flag-parsing script in favor of direct command execution via
slack ${{ inputs.command }}Added
--skip-updateflag to prevent auto-updates during installationEnabled
SLACK_DISABLE_TELEMETRYvariable so usage won’t bump up numbers in collecting metricsUpdated logging to match GitHub's logger
Moved major logic into action.yml as a proper composite action
Requirements