fix: error in ci when interactive inputs are required

Author: zimeg

internal/iostreams/prompts.go

@@ -192,18 +192,30 @@ func errInteractivityFlags(cfg PromptConfig) error {
 // ConfirmPrompt prompts the user for a "yes" or "no" (true or false) value for
 // the message
 func (io *IOStreams) ConfirmPrompt(ctx context.Context, message string, defaultValue bool) (bool, error) {
+	if !io.IsTTY() {
+		return false, errInteractivityFlags(ConfirmPromptConfig{})
+	}
 	return confirmForm(io, ctx, message, defaultValue)
 }
 
 // InputPrompt prompts the user for a string value for the message, which can
 // optionally be made required
 func (io *IOStreams) InputPrompt(ctx context.Context, message string, cfg InputPromptConfig) (string, error) {
+	if !io.IsTTY() {
+		if cfg.IsRequired() {
+			return "", errInteractivityFlags(cfg)
+		}
+		return "", nil
+	}
 	return inputForm(io, ctx, message, cfg)
 }
 
 // MultiSelectPrompt prompts the user to select multiple values in a list and
 // returns the selected values
 func (io *IOStreams) MultiSelectPrompt(ctx context.Context, message string, options []string) ([]string, error) {
+	if !io.IsTTY() {
+		return nil, errInteractivityFlags(MultiSelectPromptConfig{})
+	}
 	return multiSelectForm(io, ctx, message, options)
 }
 

internal/iostreams/prompts_test.go

@@ -273,6 +273,97 @@ func TestPasswordPrompt(t *testing.T) {
 	}
 }
 
+func TestConfirmPrompt(t *testing.T) {
+	tests := map[string]struct {
+		expectedError string
+	}{
+		"error if non-TTY": {
+			expectedError: slackerror.ErrPrompt,
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			ctx := slackcontext.MockContext(t.Context())
+
+			fsMock := slackdeps.NewFsMock()
+			osMock := slackdeps.NewOsMock()
+			osMock.On("Stdout").Return(&slackdeps.FileMock{FileInfo: &slackdeps.FileInfoNamedPipe{}})
+			cfg := config.NewConfig(fsMock, osMock)
+			io := NewIOStreams(cfg, fsMock, osMock)
+
+			_, err := io.ConfirmPrompt(ctx, "Continue?", false)
+
+			assert.Error(t, err)
+			assert.Equal(t, tc.expectedError, slackerror.ToSlackError(err).Code)
+		})
+	}
+}
+
+func TestInputPrompt(t *testing.T) {
+	tests := map[string]struct {
+		required      bool
+		expectedError string
+		expectedValue string
+	}{
+		"error if non-TTY and required": {
+			required:      true,
+			expectedError: slackerror.ErrPrompt,
+		},
+		"no error if non-TTY and optional": {
+			required:      false,
+			expectedValue: "",
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			ctx := slackcontext.MockContext(t.Context())
+
+			fsMock := slackdeps.NewFsMock()
+			osMock := slackdeps.NewOsMock()
+			osMock.On("Stdout").Return(&slackdeps.FileMock{FileInfo: &slackdeps.FileInfoNamedPipe{}})
+			cfg := config.NewConfig(fsMock, osMock)
+			io := NewIOStreams(cfg, fsMock, osMock)
+
+			value, err := io.InputPrompt(ctx, "Enter name", InputPromptConfig{
+				Required: tc.required,
+			})
+
+			if err != nil {
+				assert.Equal(t, tc.expectedError, slackerror.ToSlackError(err).Code)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, tc.expectedValue, value)
+			}
+		})
+	}
+}
+
+func TestMultiSelectPrompt(t *testing.T) {
+	tests := map[string]struct {
+		expectedError string
+	}{
+		"error if non-TTY": {
+			expectedError: slackerror.ErrPrompt,
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			ctx := slackcontext.MockContext(t.Context())
+
+			fsMock := slackdeps.NewFsMock()
+			osMock := slackdeps.NewOsMock()
+			osMock.On("Stdout").Return(&slackdeps.FileMock{FileInfo: &slackdeps.FileInfoNamedPipe{}})
+			cfg := config.NewConfig(fsMock, osMock)
+			io := NewIOStreams(cfg, fsMock, osMock)
+
+			_, err := io.MultiSelectPrompt(ctx, "Pick items", []string{"a", "b"})
+
+			assert.Error(t, err)
+			assert.Equal(t, tc.expectedError, slackerror.ToSlackError(err).Code)
+		})
+	}
+}
+
 func TestSelectPrompt(t *testing.T) {
 	tests := map[string]struct {
 		flagValue     string