Updated RTM user parsing to use a dict instead of a list. Updated tests to add additional coverage. (#149)

Author: Roach

slackclient/_server.py

@@ -1,7 +1,7 @@
 from slackclient._slackrequest import SlackRequest
 from slackclient._channel import Channel
 from slackclient._user import User
-from slackclient._util import SearchList
+from slackclient._util import SearchList, SearchDict
 from ssl import SSLError
 
 from websocket import create_connection
@@ -20,7 +20,7 @@ def __init__(self, token, connect=True):
         self.domain = None
         self.login_data = None
         self.websocket = None
-        self.users = SearchList()
+        self.users = SearchDict()
         self.channels = SearchList()
         self.connected = False
         self.ws_url = None
@@ -149,8 +149,7 @@ def websocket_safe_read(self):
             return data.rstrip()
 
     def attach_user(self, name, channel_id, real_name, tz):
-        if self.users.find(channel_id) is None:
-            self.users.append(User(self, name, channel_id, real_name, tz))
+        self.users.update({name: User(self, name, channel_id, real_name, tz)})
 
     def attach_channel(self, name, channel_id, members=None):
         if members is None:

slackclient/_util.py

@@ -15,3 +15,9 @@ def find(self, name):
             return items
         else:
             return None
+
+
+class SearchDict(dict):
+
+    def find(self, name):
+        return self.get(name)

tests/test_server.py

@@ -29,7 +29,10 @@ def test_Server_parse_channel_data(server, login_fixture):
 
 def test_Server_parse_user_data(server, login_fixture):
     server.parse_user_data(login_fixture["users"])
-    assert type(server.users.find('fakeuser')) == User
+    fakeuser = server.users.find('fakeuser')
+    assert type(fakeuser) == User
+    assert fakeuser == "fakeuser"
+    assert fakeuser != "someotheruser"
 
 
 def test_Server_cantconnect(server):