Skip to content

Commit e099db8

Browse files
committed
storage: no fwd ref, no NOLINT
1 parent 9905ed6 commit e099db8

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

src/entt/entity/storage.hpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -889,12 +889,9 @@ class basic_storage<Type, Entity, Allocator>
889889
* Attempting to use an entity that already belongs to the storage results
890890
* in undefined behavior.
891891
*
892-
* @tparam Args Types of arguments to use to construct the object.
893892
* @param entt A valid identifier.
894893
*/
895-
template<typename... Args>
896-
// NOLINTNEXTLINE(cppcoreguidelines-missing-std-forward)
897-
auto emplace(const entity_type entt, Args &&...) {
894+
auto emplace(const entity_type entt, const auto &...) {
898895
base_type::try_emplace(entt, false);
899896
}
900897

@@ -912,13 +909,10 @@ class basic_storage<Type, Entity, Allocator>
912909

913910
/**
914911
* @brief Assigns entities to a storage.
915-
* @tparam Args Types of optional arguments.
916912
* @param first An iterator to the first element of the range of entities.
917913
* @param last An iterator past the last element of the range of entities.
918914
*/
919-
template<typename... Args>
920-
// NOLINTNEXTLINE(cppcoreguidelines-missing-std-forward)
921-
void insert(stl::input_iterator auto first, stl::input_iterator auto last, Args &&...) {
915+
void insert(stl::input_iterator auto first, stl::input_iterator auto last, const auto &...) {
922916
for(; first != last; ++first) {
923917
base_type::try_emplace(*first, true);
924918
}

0 commit comments

Comments
 (0)