Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default min_hops to 1 #1935

Open
0pcom opened this issue Feb 14, 2025 · 1 comment
Open

Change default min_hops to 1 #1935

0pcom opened this issue Feb 14, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@0pcom
Copy link
Collaborator

0pcom commented Feb 14, 2025

Recent changes on develop have altered the way that min_hops is interpreted with regards to routing. Now, a value of 0 will basically block routes from being created by the visor. We need to change the default min_hops to 1 so that routing will work with the default config which is generated - before v1.3.29 is released.

@0pcom 0pcom added the bug Something isn't working label Feb 14, 2025
@0pcom
Copy link
Collaborator Author

0pcom commented Feb 16, 2025

It should be noted in the documentation that setting min_hops as 2 does not prevent a single hop route from being used, it merely prevents auto-transport creation. This seems incorrect, but it should be noted in documentation if nothing else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant