Skip to content

Commit 4507d0f

Browse files
committed
fix: remove MockerBrokenConv override
The override was failing due to `ConvMock.btor` not being virtual. When I added the `virtual` modifier, for some reason `forge build --sizes` fail because the MockConv contract becomes too big.
1 parent fcb2478 commit 4507d0f

2 files changed

Lines changed: 12 additions & 8 deletions

File tree

src/SPBEAM.t.sol

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,12 @@ contract InitCaller {
4343
}
4444
}
4545

46-
contract MockBrokenConv is ConvMock {
47-
function btor(uint256 /* bps */ ) public pure override returns (uint256) {
46+
contract MockBrokenConv {
47+
function rtob(uint256 /* ray */ ) public pure returns (uint256) {
48+
return 0;
49+
}
50+
51+
function btor(uint256 /* bps */ ) public pure returns (uint256) {
4852
return 0;
4953
}
5054
}

src/mocks/ConvMock.sol

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20014,16 +20014,16 @@ contract ConvMock {
2001420014
rayToBps[1000000021979553151239153027] = 10000;
2001520015
}
2001620016

20017-
function btor(uint256 bps) public view virtual returns (uint256 ray) {
20018-
require(bps <= MAX_BPS_IN, "DSPC/bps-too-high");
20017+
function btor(uint256 bps) public view returns (uint256 ray) {
20018+
require(bps <= MAX_BPS_IN, "Conv/bps-too-high");
2001920019
ray = bpsToRay[bps];
20020-
require(ray != 0, "DSPC/out-of-bounds");
20020+
require(ray != 0, "Conv/out-of-bounds");
2002120021
}
2002220022

20023-
function rtob(uint256 ray) public view virtual returns (uint256 bps) {
20024-
require(ray >= RAY, "DSPC/ray-too-low");
20023+
function rtob(uint256 ray) public view returns (uint256 bps) {
20024+
require(ray >= RAY, "Conv/ray-too-low");
2002520025
bps = rayToBps[ray];
2002620026
// Check if it's in range
20027-
require(bpsToRay[bps] == ray, "DSPC/out-of-bounds");
20027+
require(bpsToRay[bps] == ray, "Conv/out-of-bounds");
2002820028
}
2002920029
}

0 commit comments

Comments
 (0)