Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for try/catch #554

Open
sjbarag opened this issue Sep 29, 2020 · 0 comments
Open

Add support for try/catch #554

sjbarag opened this issue Sep 29, 2020 · 0 comments
Labels
enhancement Any addition to this project's existing capabilities interpreter Affects this project's tree-walking interpreter lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser

Comments

@sjbarag
Copy link
Owner

sjbarag commented Sep 29, 2020 •
edited
Loading

The Reference BrightScript Implementation (RBI) added support for try/catch/throw in version 9.4! https://developer.roku.com/docs/references/brightscript/language/error-handling.md

We should do the same. This work will involve the lexer, parser, and interpreter, and may require some extra changes in the standard library to accommodate.
@sjbarag sjbarag added enhancement Any addition to this project's existing capabilities lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser interpreter Affects this project's tree-walking interpreter labels Sep 29, 2020
sjbarag added a commit that referenced this issue Jan 15, 2021
@sjbarag
feat(lex): Emit try/catch/throw lexemes for parsing
6748221 
RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see #554
sjbarag added a commit that referenced this issue Jan 19, 2021
@sjbarag
feat(lex): Emit try/catch/throw lexemes for parsing
cbe5229 
RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see #554
@sjbarag sjbarag mentioned this issue Jan 19, 2021
Open
sjbarag added a commit that referenced this issue Jan 19, 2021
@sjbarag
feat(parse): Consume try, catch, and end try lexemes
fe9077e 
Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see #554
sjbarag added a commit that referenced this issue Jan 19, 2021
@sjbarag
feat(parse): Consume try, catch, and end try lexemes
a5487ed 
Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see #554
lvcabral pushed a commit to lvcabral/brs-engine that referenced this issue Nov 29, 2023
@sjbarag @lvcabral
feat(parse): Consume try, catch, and end try lexemes
98a8962 
Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naively.

see sjbarag/brs#554#554
lvcabral pushed a commit to lvcabral/brs-engine that referenced this issue Nov 29, 2023
@sjbarag @lvcabral
feat(lex): Emit try/catch/throw lexemes for parsing
d4f477a 
RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see sjbarag/brs#554
lvcabral pushed a commit to rokucommunity/brs that referenced this issue Nov 29, 2023
@sjbarag @lvcabral
feat(lex): Emit try/catch/throw lexemes for parsing
ca96bde 
RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see sjbarag#554
lvcabral pushed a commit to rokucommunity/brs that referenced this issue Nov 29, 2023
@sjbarag @lvcabral
feat(parse): Consume try, catch, and end try lexemes
d2c5ef4 
Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see sjbarag#554
This was referenced Nov 29, 2023
Merged
Merged
lvcabral added a commit to lvcabral/brs-engine that referenced this issue Nov 29, 2023
@lvcabral @sjbarag
feat(lex,parse): Add stub try/catch implementation (#195)
48c2c4f 
* feat(parse): Consume try, catch, and end try lexemes

Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naively.

see sjbarag/brs#554#554

* feat(lex): Emit try/catch/throw lexemes for parsing

RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see sjbarag/brs#554

* Removing `super()` from TryCatch statement implementation

---------

Co-authored-by: Sean Barag <[email protected]>
TwitchBronBron added a commit to rokucommunity/brs that referenced this issue Dec 1, 2023
@lvcabral @sjbarag @TwitchBronBron
feat(lex,parse): Add stub try/catch implementation (#34)
b8e459a 
* feat(lex): Emit try/catch/throw lexemes for parsing

RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see sjbarag#554

* feat(parse): Consume try, catch, and end try lexemes

Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see sjbarag#554

* Fixed Test Case

---------

Co-authored-by: Sean Barag <[email protected]>
Co-authored-by: Bronley Plumb <[email protected]>
lvcabral pushed a commit to rokucommunity/brs that referenced this issue Apr 4, 2024
@sjbarag @lvcabral
feat(parse): Consume try, catch, and end try lexemes
f2851e7 
Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see sjbarag#554
lvcabral pushed a commit to rokucommunity/brs that referenced this issue Apr 4, 2024
@sjbarag @lvcabral
feat(parse): Consume try, catch, and end try lexemes
5f025c8 
Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see sjbarag#554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any addition to this project's existing capabilities interpreter Affects this project's tree-walking interpreter lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjbarag