Make sure splitlines is not called on None (#161)

ptosco · Tosco, Paolo · web-flow · commit e367e9cbf1e4 · 2023-10-21T01:31:28.000Z
Small change that avoids that `splitlines` is called on a `None` object;
this may currently happen if `prop.fget.__doc__` exists and is `None`,
thus causing an exception (`'NoneType' object has no attribute
'splitlines'`).

Co-authored-by: Tosco, Paolo &lt;paolo.tosco@novartis.com&gt;
diff --git a/pybind11_stubgen/parser/mixins/parse.py b/pybind11_stubgen/parser/mixins/parse.py
@@ -502,7 +502,7 @@ def handle_property(self, path: QualifiedName, prop: Any) -> Property | None:
                 result.doc == result.getter.doc
                 or result.doc
                 == self._strip_empty_lines(
-                    getattr(prop.fget, "__doc__", "").splitlines()
+                    (getattr(prop.fget, "__doc__", "") or "").splitlines()
                 )
             )
         ):

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ def handle_property(self, path: QualifiedName, prop: Any) -> Property \| None:`
`502`	`502`	`result.doc == result.getter.doc`
`503`	`503`	`or result.doc`
`504`	`504`	`== self._strip_empty_lines(`
`505`		`- getattr(prop.fget, "__doc__", "").splitlines()`
	`505`	`+ (getattr(prop.fget, "__doc__", "") or "").splitlines()`
`506`	`506`	`)`
`507`	`507`	`)`
`508`	`508`	`):`